Optimize Options Source Gen when no need to run #93427
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging subscribers to this area: @dotnet/area-extensions-options Issue DetailsThis should contribute to improvements in the results of speedometer and Visual Studio (VS) tests, which have exhibited regressions.
|
tarekgh
added
the
source-generator
ericstj
approved these changes
Oct 12, 2023
eiriktsarpalis
approved these changes
Oct 13, 2023
|
failures are tracked by #92423 which are unrelated. I am not sure why the build analysis didn't detect it. |
|
/backport to release/8.0 |
|
Started backporting to release/8.0: https://github.com/dotnet/runtime/actions/runs/6510949878 |
|
@tarekgh is this already in VS main? would you point me to the insertion PR if yes? We would like to coordinate Roslyn side paired changes post that. cc: @CyrusNajmabadi |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should contribute to improvements in the results of speedometer and Visual Studio (VS) tests, which have exhibited regressions. This contribute a little to #93313 too.