[release/8.0] Workaround for C++ compiler bug on Arm64 #93528
Conversation
|
Tagging subscribers to this area: @tommcdon Issue DetailsBackport of #93523 to release/8.0 MSVC rolled out to the build machines a few days ago has a codegen bug that affects the JIT on Arm64. We are applying a temporary workaround to disable optimizations around the affected methods. Customer ImpactMultiplication of two constants produce bad result in some cases. TestingThe affected JIT tests are passing. RiskLow
|
jkotas
added
Servicing-consider
|
/backport to release/7.0 |
|
/backport to release/6.0 |
|
Started backporting to release/7.0: https://github.com/dotnet/runtime/actions/runs/6525097146 |
|
Started backporting to release/6.0: https://github.com/dotnet/runtime/actions/runs/6525097808 |
|
@jkotas backporting to release/6.0 failed, the patch most likely resulted in conflicts: $ git am --3way --ignore-whitespace --keep-non-patch changes.patch
Applying: Delete outdated workaround
Applying: Workaround for https://github.com/dotnet/runtime/issues/93442
Using index info to reconstruct a base tree...
M src/coreclr/inc/safemath.h
Falling back to patching base and 3-way merge...
Auto-merging src/coreclr/inc/safemath.h
CONFLICT (content): Merge conflict in src/coreclr/inc/safemath.h
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0002 Workaround for https://github.com/dotnet/runtime/issues/93442
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".
Error: The process '/usr/bin/git' failed with exit code 128Please backport manually! |
|
@jkotas an error occurred while backporting to release/6.0, please check the run log for details! Error: git am failed, most likely due to a merge conflict. |
jkotas
added
the
area-CodeGen-coreclr
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch Issue DetailsBackport of #93523 to release/8.0 MSVC rolled out to the build machines a few days ago has a codegen bug that affects the JIT on Arm64. We are applying a temporary workaround to disable optimizations around the affected methods. Customer ImpactMultiplication of two constants produce bad result in some cases. TestingThe affected JIT tests are passing. RiskLow
|
jkotas
force-pushed
the
issue-93442-8.0
branch
from
c4173df
to
2c7fd4d
Compare
jeffschwMSFT
added
Servicing-approved
ghost
locked as resolved and limited conversation to collaborators
Backport of #93523 to release/8.0
MSVC rolled out to the build machines a few days ago has a codegen bug that affects the JIT on Arm64. We are applying a temporary workaround to disable optimizations around the affected methods.
Customer Impact
Multiplication of two constants produces bad result in some cases.
Testing
The affected JIT tests are passing.
Risk
Low