Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/7.0-staging] Workaround for C++ compiler bug on Arm64 #93529

Merged
merged 1 commit into from
Oct 16, 2023

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Oct 15, 2023

Backport of #93523 to release/7.0

MSVC rolled out to the build machines a few days ago has a codegen bug that affects the JIT on Arm64. We are applying a temporary workaround to disable optimizations around the affected methods.

Customer Impact

Multiplication of two constants produces bad result in some cases.

Testing

The affected JIT tests are passing.

Risk

Low

@ghost
Copy link

ghost commented Oct 15, 2023

Tagging subscribers to this area: @tommcdon
See info in area-owners.md if you want to be subscribed.

Issue Details

Backport of #93528 to release/7.0

/cc @jkotas

Customer Impact

Testing

Risk

IMPORTANT: If this backport is for a servicing release, please verify that:

  • The PR target branch is release/X.0-staging, not release/X.0.

  • If the change touches code that ships in a NuGet package, you have added the necessary package authoring and gotten it explicitly reviewed.

Author: github-actions[bot]
Assignees: -
Labels:

area-Diagnostics-coreclr

Milestone: -

@jkotas jkotas changed the title [release/7.0] [release/8.0] Workaround for C++ compiler bug on Arm64 [release/7.0] Workaround for C++ compiler bug on Arm64 Oct 15, 2023
@jkotas jkotas changed the base branch from release/7.0 to release/7.0-staging October 15, 2023 16:09
@jkotas jkotas added area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI and removed area-Diagnostics-coreclr labels Oct 15, 2023
@ghost
Copy link

ghost commented Oct 15, 2023

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

Issue Details

Backport of #93523 to release/7.0

MSVC rolled out to the build machines a few days ago has a codegen bug that affects the JIT on Arm64. We are applying a temporary workaround to disable optimizations around the affected methods.

Customer Impact

Multiplication of two constants produces bad result in some cases.

Testing

The affected JIT tests are passing.

Risk

Low

Author: github-actions[bot]
Assignees: -
Labels:

area-CodeGen-coreclr, area-Diagnostics-coreclr

Milestone: -

@jkotas jkotas changed the title [release/7.0] Workaround for C++ compiler bug on Arm64 [release/7.0-staging] Workaround for C++ compiler bug on Arm64 Oct 15, 2023
Copy link
Member

@jeffschwMSFT jeffschwMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved. we will take for consideration in 7.0.x

@jeffschwMSFT jeffschwMSFT added the Servicing-consider Issue for next servicing release review label Oct 15, 2023
@jeffschwMSFT jeffschwMSFT added this to the 7.0.x milestone Oct 15, 2023
@jkotas jkotas force-pushed the backport/pr-93528-to-release/7.0 branch from 5f3324b to c2844c7 Compare October 15, 2023 16:33
@jeffschwMSFT jeffschwMSFT added Servicing-approved Approved for servicing release and removed Servicing-consider Issue for next servicing release review labels Oct 16, 2023
@jkotas jkotas merged commit 69483a0 into release/7.0-staging Oct 16, 2023
110 of 111 checks passed
@jkotas jkotas deleted the backport/pr-93528-to-release/7.0 branch October 16, 2023 18:27
@ghost ghost locked as resolved and limited conversation to collaborators Nov 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI Servicing-approved Approved for servicing release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants