Honor JsonSerializerOptions.PropertyNameCaseInsensitive in property name conflict resolution. #93933
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ame conflict resolution.
|
Tagging subscribers to this area: @dotnet/area-system-text-json, @gregsdennis Issue DetailsThe PR in #81306 among other things consolidated the property name conflict resolution algorithm to a shared location in Fix #93903.
|
jeffhandley
approved these changes
Oct 24, 2023
src/libraries/System.Text.Json/tests/Common/PropertyNameTests.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: Jeff Handley <jeffhandley@users.noreply.github.com>
|
/backport to release/8.0 |
|
Started backporting to release/8.0: https://github.com/dotnet/runtime/actions/runs/6630600960 |
tarekgh
reviewed
Oct 24, 2023
src/libraries/System.Text.Json/tests/Common/PropertyNameTests.cs
Outdated
Show resolved
Hide resolved
tarekgh
approved these changes
Oct 24, 2023
tarekgh
approved these changes
Oct 24, 2023
liveans
pushed a commit
to liveans/dotnet-runtime
that referenced
this pull request
Nov 9, 2023
…ame conflict resolution. (dotnet#93933) * Honor JsonSerializerOptions.PropertyNameCaseInsensitive in property name conflict resolution. * Update src/libraries/System.Text.Json/tests/Common/PropertyNameTests.cs Co-authored-by: Jeff Handley <jeffhandley@users.noreply.github.com> * Address feedback --------- Co-authored-by: Jeff Handley <jeffhandley@users.noreply.github.com>
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR in #81306 among other things consolidated the property name conflict resolution algorithm to a shared location in
JsonTypeInfo, however the shared logic didn't account for theJsonSerializerOptions.PropertyNameCaseInsensitivesetting. This PR rectifies the issue and adds a regression test.Fix #93903.