-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support TimeSpan with RangeAttribute in Options validation source generator #94798
Support TimeSpan with RangeAttribute in Options validation source generator #94798
Conversation
Tagging subscribers to this area: @dotnet/area-extensions-options Issue Details
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM modulo one question I had.
I tested this fix with the https://github.com/dotnet/extensions/tree/main/src/Libraries/Microsoft.Extensions.Http.Resilience library (which uses the Options Validation source generator) and I'm able to successfully publish a Native AOT application using the library built with this fix with no AOT warnings. Thanks, @tarekgh! |
/backport to release/8.0-staging |
Started backporting to release/8.0-staging: https://github.com/dotnet/runtime/actions/runs/6894206422 |
#94119