Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/8.0] Update dependencies from dotnet/roslyn #94877

Conversation

dotnet-maestro[bot]
Copy link
Contributor

This pull request updates the following dependencies

From https://github.com/dotnet/roslyn

  • Subscription: ac2d12d7-7c98-40fe-ec67-08db9e4ff4ff
  • Build: 20231116.2
  • Date Produced: November 16, 2023 8:28:35 PM UTC
  • Commit: 7b75981cf3bd520b86ec4ed00ec156c8bc48e4eb
  • Branch: refs/heads/release/dev17.8

…116.2

Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
 From Version 4.8.0-7.23558.1 -> To Version 4.8.0-7.23566.2
@dotnet-issue-labeler dotnet-issue-labeler bot added the area-codeflow for labeling automated codeflow label Nov 16, 2023
@carlossanlop carlossanlop added the Servicing-approved Approved for servicing release label Nov 17, 2023
Copy link
Member

@carlossanlop carlossanlop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since @mmitche signed-off the emsdk one for 8.0 (I assume that means we need it for the December Release), then I'll also merge this one.

@carlossanlop carlossanlop merged commit 7681675 into release/8.0 Nov 17, 2023
189 of 192 checks passed
@carlossanlop carlossanlop deleted the darc-release/8.0-5915b77e-8264-4b75-bdc0-38fc23807562 branch November 17, 2023 01:50
@mmitche
Copy link
Member

mmitche commented Nov 17, 2023

Since @mmitche signed-off the emsdk one for 8.0 (I assume that means we need it for the December Release), then I'll also merge this one.

I think we should probably disable the roslyn flow into runtime for the release branch now. For servicing, we should only be relying on the released SDKs.

@carlossanlop
Copy link
Member

Ok sure, I can do that. Do you mean I should disable it for 6.0, 7.0 and 8.0? or just 8.0?

@mmitche
Copy link
Member

mmitche commented Nov 17, 2023

Looks like it's only enabled for 8.0 right now, so just 8.0

@github-actions github-actions bot locked and limited conversation to collaborators Dec 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-codeflow for labeling automated codeflow Servicing-approved Approved for servicing release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants