Fix concurrency issue in TypeDescriptor GetProperties() and GetConverter() #96846
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Originally a race condition exists in `CheckDefaultProvider` and leads to wrong results when many methods are called simultaneously. The PR fixes that by extending the lock statement. Fix dotnet#92934
to wrong results when many methods are called simultaneously. The PR fixes that by extending the lock statement. Fix dotnet#92394
Moved tests to the main testing file Adopted tests from dotnet#85156 Co-authored-by: Maximys <mixim33@yandex.ru>
ConcurrentGetProperties_ReturnsExpected is skipped on browsers because Thread.Start is unsupported.
|
Tagging subscribers to this area: @dotnet/area-system-componentmodel Issue DetailsReplaces (and is derived from the same branch as) PR #92548 in order to apply the "sentinel" pattern so that we don't need a new Hashtable instance. Thanks karakasa and Maximys for your work on this.
|
This was referenced Jan 11, 2024
ericstj
reviewed
Jan 11, 2024
src/libraries/System.ComponentModel.TypeConverter/src/System/ComponentModel/TypeDescriptor.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.ComponentModel.TypeConverter/src/System/ComponentModel/TypeDescriptor.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.ComponentModel.TypeConverter/src/System/ComponentModel/TypeDescriptor.cs
Outdated
Show resolved
Hide resolved
ericstj
approved these changes
Jan 12, 2024
Yes, I reverted the changes from the previous PR and the 3 new tests failed. Then I added back the changes and the tests passed. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #92394
Fixes #30024
Replaces (and is derived from the same branch as) PR #92521 in order to apply the "sentinel" pattern so that we don't need a new Hashtable instance. Thanks karakasa and Maximys for your work on this.