Make TypeDescriptor thread safe with custom providers and minimize lock use
#92548
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Originally a race condition exists in `CheckDefaultProvider` and leads to wrong results when many methods are called simultaneously. The PR fixes that by extending the lock statement. Fix dotnet#92934
to wrong results when many methods are called simultaneously. The PR fixes that by extending the lock statement. Fix dotnet#92394
ghost
added
the
community-contribution
|
Tagging subscribers to this area: @dotnet/area-system-componentmodel Issue DetailsFix #92394 Similar to #92521 but the PR takes a more aggressive approach. The PR creates specialized versions of
|
|
Sometimes the PR causes stack overflow. Reject. |
This was referenced Sep 24, 2023
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix #92394
Similar to #92521 but the PR takes a more aggressive approach. The PR creates specialized versions of
AddProviderandNodeFor(Type)for use inCheckDefaultProviderto minimize lock. Though the side effects are not fully reviewed due to control flow change.Risk
The performance should be close to, or better than, the before-PR implementation because the
lockstatement doesn't change.The PR might introduce bugs as it puts
s_defaultProviders[type] = nullafterAddProvider.