Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove remaining CRT PAL wrappers and enable including standard headers in the CoreCLR build #98336

Merged
merged 68 commits into from
Apr 4, 2024
Merged

Remove remaining CRT PAL wrappers and enable including standard headers in the CoreCLR build #98336

merged 68 commits into from
Apr 4, 2024

Commits on Feb 15, 2024

  1. Remove PAL_exit as the only usages are in places where we don't use P… 

    …AL features that would need global cleanup before process exit.
    @jkoritzinsky
    jkoritzinsky committed Feb 15, 2024
    Configuration menu
    Copy the full SHA
    ffee875 View commit details
    Browse the repository at this point in the history

  2. Remove rand PAL API as no one uses it.

    @jkoritzinsky
    jkoritzinsky committed Feb 15, 2024
    Configuration menu
    Copy the full SHA
    04ea4b4 View commit details
    Browse the repository at this point in the history

  3. Remove PAL_realloc as no usage of it would ever pass an alloc size of 0.

    @jkoritzinsky
    jkoritzinsky committed Feb 15, 2024
    Configuration menu
    Copy the full SHA
    2527c50 View commit details
    Browse the repository at this point in the history

  4. Remove PAL_free as it just forwards to free.

    @jkoritzinsky
    jkoritzinsky committed Feb 15, 2024
    Configuration menu
    Copy the full SHA
    610d49f View commit details
    Browse the repository at this point in the history

  5. Remove malloc PAL API and update the few places that could have passe… 

    …d in a zero size to bump it to 1 manually on all platforms.
    @jkoritzinsky
    jkoritzinsky committed Feb 15, 2024
    Configuration menu
    Copy the full SHA
    6f5d947 View commit details
    Browse the repository at this point in the history

  6. Remove AMD64 processor PAL functions

    @jkoritzinsky
    jkoritzinsky committed Feb 15, 2024
    Configuration menu
    Copy the full SHA
    33f3224 View commit details
    Browse the repository at this point in the history

  7. Remove time PAL as it's unused

    @jkoritzinsky
    jkoritzinsky committed Feb 15, 2024
    Configuration menu
    Copy the full SHA
    86f4ea7 View commit details
    Browse the repository at this point in the history

  8. Explicitly use the PAL's getenv implementation in the few places we w… 

    …ere using it through the define.
    @jkoritzinsky
    jkoritzinsky committed Feb 15, 2024
    Configuration menu
    Copy the full SHA
    865eefb View commit details
    Browse the repository at this point in the history

  9. Suppress bad static-analysis warning

    @jkoritzinsky
    jkoritzinsky committed Feb 15, 2024
    Configuration menu
    Copy the full SHA
    188b02d View commit details
    Browse the repository at this point in the history

  10. Remove bsearch and qsort PAL APIs as they only forward to the underly… 

    …ing impl and maintain PAL logging
    @jkoritzinsky
    jkoritzinsky committed Feb 15, 2024
    Configuration menu
    Copy the full SHA
    57e6a10 View commit details
    Browse the repository at this point in the history

  11. Remove CRT PAL, CLR STL PAL, and enable including CRT and STL headers.

    @jkoritzinsky
    jkoritzinsky committed Feb 15, 2024
    Configuration menu
    Copy the full SHA
    b528590 View commit details
    Browse the repository at this point in the history

  12. Various changes to fix the Windows build.

    @jkoritzinsky
    jkoritzinsky committed Feb 15, 2024
    Configuration menu
    Copy the full SHA
    309e330 View commit details
    Browse the repository at this point in the history

  13. Remove min/max macros from NativeAOT and fix other build failures on … 

    …non-Windows.
    @jkoritzinsky
    jkoritzinsky committed Feb 15, 2024
    Configuration menu
    Copy the full SHA
    108f83d View commit details
    Browse the repository at this point in the history

  14. Remove duplicate definitions, fix callconv build failure. Disable war… 

    …ning on GCC that catches more cases than Clang, at least for now
    @jkoritzinsky
    jkoritzinsky committed Feb 15, 2024
    Configuration menu
    Copy the full SHA
    16a04e0 View commit details
    Browse the repository at this point in the history

Commits on Feb 16, 2024

  1. Force C++ linkage when including the C++ standard headers (some files… 

    … in the build include the PAL headers in an extern C block)
    @jkoritzinsky
    jkoritzinsky committed Feb 16, 2024
    Configuration menu
    Copy the full SHA
    d8afe1d View commit details
    Browse the repository at this point in the history

  2. Add missing includes/usings.

    @jkoritzinsky
    jkoritzinsky committed Feb 16, 2024
    Configuration menu
    Copy the full SHA
    e8c8846 View commit details
    Browse the repository at this point in the history

Commits on Feb 20, 2024

  1. Fix some build errors

    @jkoritzinsky
    jkoritzinsky committed Feb 20, 2024
    Configuration menu
    Copy the full SHA
    ce1f3e3 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' of github.com:dotnet/runtime into misc-pal

    @jkoritzinsky
    jkoritzinsky committed Feb 20, 2024
    Configuration menu
    Copy the full SHA
    03963c5 View commit details
    Browse the repository at this point in the history

  3. Remove malloc wrapper and simplify InternalNew

    @jkoritzinsky
    jkoritzinsky committed Feb 20, 2024
    Configuration menu
    Copy the full SHA
    c7e6dc3 View commit details
    Browse the repository at this point in the history

  4. Remove cruntime/misc.cpp PAL APIs and inline usages of _gcvt_s

    @jkoritzinsky
    jkoritzinsky committed Feb 20, 2024
    Configuration menu
    Copy the full SHA
    03a06fb View commit details
    Browse the repository at this point in the history

  5. Fix more build failures

    @jkoritzinsky
    jkoritzinsky committed Feb 20, 2024
    Configuration menu
    Copy the full SHA
    54d2c8e View commit details
    Browse the repository at this point in the history

Commits on Feb 23, 2024

  1. Fix various build failures.

    @jkoritzinsky
    jkoritzinsky committed Feb 23, 2024
    Configuration menu
    Copy the full SHA
    90ad1fe View commit details
    Browse the repository at this point in the history

Commits on Feb 26, 2024

  1. Fix various build failures.

    @jkoritzinsky
    jkoritzinsky committed Feb 26, 2024
    Configuration menu
    Copy the full SHA
    a024484 View commit details
    Browse the repository at this point in the history

  2. Fix define and fix more community-leg failures.

    @jkoritzinsky
    jkoritzinsky committed Feb 26, 2024
    Configuration menu
    Copy the full SHA
    d3aec5e View commit details
    Browse the repository at this point in the history

Commits on Mar 8, 2024

  1. Various osx and gcc fixes

    @jkoritzinsky
    jkoritzinsky committed Mar 8, 2024
    Configuration menu
    Copy the full SHA
    27fd400 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' of github.com:dotnet/runtime into misc-pal

    @jkoritzinsky
    jkoritzinsky committed Mar 8, 2024
    Configuration menu
    Copy the full SHA
    0c4e83a View commit details
    Browse the repository at this point in the history

  3. Define RC_INVOKED when preprocessing RC files and fix more NULL->TADD… 

    …R/PCODE conversions for GCC
    @jkoritzinsky
    jkoritzinsky committed Mar 8, 2024
    Configuration menu
    Copy the full SHA
    5cfe483 View commit details
    Browse the repository at this point in the history

Commits on Mar 11, 2024

  1. Disable the NULL arithmetic and conversion warnings in CoreCLR to avo… 

    …id making more NULL fixes than the CRT changes.
    @jkoritzinsky
    jkoritzinsky committed Mar 11, 2024
    Configuration menu
    Copy the full SHA
    d49ae0c View commit details
    Browse the repository at this point in the history

  2. One more malloc header fix.

    @jkoritzinsky
    jkoritzinsky committed Mar 11, 2024
    Configuration menu
    Copy the full SHA
    75529ac View commit details
    Browse the repository at this point in the history

  3. Various build fixes/adjustments

    @jkoritzinsky
    jkoritzinsky committed Mar 11, 2024
    Configuration menu
    Copy the full SHA
    83a4d19 View commit details
    Browse the repository at this point in the history

  4. Further build fixes

    @jkoritzinsky
    jkoritzinsky committed Mar 11, 2024
    Configuration menu
    Copy the full SHA
    2d195d1 View commit details
    Browse the repository at this point in the history

  5. Apply format patch

    @jkoritzinsky
    jkoritzinsky committed Mar 11, 2024
    Configuration menu
    Copy the full SHA
    110965d View commit details
    Browse the repository at this point in the history

Commits on Mar 12, 2024

  1. Fix GCC build and continue to work on the linux-x86 build

    @jkoritzinsky
    jkoritzinsky committed Mar 12, 2024
    Configuration menu
    Copy the full SHA
    141f08c View commit details
    Browse the repository at this point in the history

  2. Ensure that we're doing an unsigned compare with the result of unsign… 

    …ed abs, not converting back to a signed compare (which would produce the incorrect result for SSIZE_T_MIN)
    @jkoritzinsky
    jkoritzinsky committed Mar 12, 2024
    Configuration menu
    Copy the full SHA
    ab910e6 View commit details
    Browse the repository at this point in the history

  3. Remove malloc.h include except for where we're pulling it in for _alloca

    @jkoritzinsky
    jkoritzinsky committed Mar 12, 2024
    Configuration menu
    Copy the full SHA
    2ae3160 View commit details
    Browse the repository at this point in the history

  4. Undo unsigned largestAlignmentRequirement

    @jkoritzinsky
    jkoritzinsky committed Mar 12, 2024
    Configuration menu
    Copy the full SHA
    2e45f86 View commit details
    Browse the repository at this point in the history

  5. Explicitly use the C++ abs signature as we did in the rest of the jit

    @jkoritzinsky
    jkoritzinsky committed Mar 12, 2024
    Configuration menu
    Copy the full SHA
    a11db1d View commit details
    Browse the repository at this point in the history

  6. Merge branch 'main' of github.com:dotnet/runtime into misc-pal

    @jkoritzinsky
    jkoritzinsky committed Mar 12, 2024
    Configuration menu
    Copy the full SHA
    bae9c94 View commit details
    Browse the repository at this point in the history

Commits on Mar 13, 2024

  1. Remove constant manipulation as that wasn't the problem and add missi… 

    …ng include for Windows debug build.
    @jkoritzinsky
    jkoritzinsky committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    cf9efb2 View commit details
    Browse the repository at this point in the history

  2. Include malloc.h on windows for the whole JIT

    @jkoritzinsky
    jkoritzinsky committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    eb0180d View commit details
    Browse the repository at this point in the history

Commits on Mar 14, 2024

  1. Fix PAL tests and update pal test script's usage information.

    @jkoritzinsky
    jkoritzinsky committed Mar 14, 2024
    Configuration menu
    Copy the full SHA
    fb30172 View commit details
    Browse the repository at this point in the history

  2. Remove PAL_STDCPP_COMPAT and remove min/max macro in the GC space and… 

    … use the better-inference implementation from the JIT in the GC as well.
    @jkoritzinsky
    jkoritzinsky committed Mar 14, 2024
    Configuration menu
    Copy the full SHA
    93c34c4 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' of github.com:dotnet/runtime into misc-pal 

    # Conflicts:
#	src/coreclr/jit/fgdiagnostic.cpp
    @jkoritzinsky
    jkoritzinsky committed Mar 14, 2024
    Configuration menu
    Copy the full SHA
    d5b82a1 View commit details
    Browse the repository at this point in the history

  4. Various build fixes and PR feedback

    @jkoritzinsky
    jkoritzinsky committed Mar 14, 2024
    Configuration menu
    Copy the full SHA
    1a0ee6c View commit details
    Browse the repository at this point in the history

  5. Fix build errors

    @jkoritzinsky
    jkoritzinsky committed Mar 14, 2024
    Configuration menu
    Copy the full SHA
    57ed663 View commit details
    Browse the repository at this point in the history

Commits on Mar 15, 2024

  1. Set NOMINMAX globally and move the CoreCLR and NativeAOT builds to ne… 

    …ver use min/max macros, even on Windows.
    @jkoritzinsky
    jkoritzinsky committed Mar 15, 2024
    Configuration menu
    Copy the full SHA
    705bf68 View commit details
    Browse the repository at this point in the history

  2. Move standard headers to the top to avoid having the "debug return" m… 

    …acro interfering with those includes. Fix some pointer assignments now that this puts NULL in scope earlier.
    @jkoritzinsky
    jkoritzinsky committed Mar 15, 2024
    Configuration menu
    Copy the full SHA
    12a6143 View commit details
    Browse the repository at this point in the history

  3. Use set_property to append the RC_INVOKED define instead of overwri… 

    …ting all source-file-level compiler definitions.
    @jkoritzinsky
    jkoritzinsky committed Mar 15, 2024
    Configuration menu
    Copy the full SHA
    a686376 View commit details
    Browse the repository at this point in the history

  4. Undef __fastcall to fix FreeBSD

    @jkoritzinsky
    jkoritzinsky committed Mar 15, 2024
    Configuration menu
    Copy the full SHA
    cef5418 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'main' of github.com:dotnet/runtime into misc-pal

    @jkoritzinsky
    jkoritzinsky committed Mar 15, 2024
    Configuration menu
    Copy the full SHA
    23f2792 View commit details
    Browse the repository at this point in the history

  6. Add more min/max casts to fix GCC build.

    @jkoritzinsky
    jkoritzinsky committed Mar 15, 2024
    Configuration menu
    Copy the full SHA
    283f254 View commit details
    Browse the repository at this point in the history

  7. Add more casts to fix GCC and windows x86 builds

    @jkoritzinsky
    jkoritzinsky committed Mar 15, 2024
    Configuration menu
    Copy the full SHA
    ee084ec View commit details
    Browse the repository at this point in the history

  8. More min/max fixes...

    @jkoritzinsky
    jkoritzinsky committed Mar 15, 2024
    Configuration menu
    Copy the full SHA
    aa54b3f View commit details
    Browse the repository at this point in the history

Commits on Mar 18, 2024

  1. More signedness mismatch fixes in gc.

    @jkoritzinsky
    jkoritzinsky committed Mar 18, 2024
    Configuration menu
    Copy the full SHA
    03b42c6 View commit details
    Browse the repository at this point in the history

Commits on Apr 1, 2024

  1. Remove USE_STL

    @jkoritzinsky
    jkoritzinsky committed Apr 1, 2024
    Configuration menu
    Copy the full SHA
    80c56da View commit details
    Browse the repository at this point in the history

  2. PR feedback

    @jkoritzinsky
    jkoritzinsky committed Apr 1, 2024
    Configuration menu
    Copy the full SHA
    0092a92 View commit details
    Browse the repository at this point in the history

  3. Remove custom min/max from SuperPMI

    @jkoritzinsky
    jkoritzinsky committed Apr 1, 2024
    Configuration menu
    Copy the full SHA
    93be569 View commit details
    Browse the repository at this point in the history

  4. Remove custom min/max from the JIT

    @jkoritzinsky
    jkoritzinsky committed Apr 1, 2024
    Configuration menu
    Copy the full SHA
    5dddd14 View commit details
    Browse the repository at this point in the history

  5. Remove min/max in the GC

    @jkoritzinsky
    jkoritzinsky committed Apr 1, 2024
    Configuration menu
    Copy the full SHA
    f9647e5 View commit details
    Browse the repository at this point in the history

Commits on Apr 2, 2024

  1. Fix more cases that only pop in 64-bit windows builds.

    @jkoritzinsky
    jkoritzinsky committed Apr 2, 2024
    Configuration menu
    Copy the full SHA
    25c9976 View commit details
    Browse the repository at this point in the history

  2. Fix failures on linux-x64 and when using a compiler that can actually… 

    … enforce C++11 compliance vs C++14 compliance.
    @jkoritzinsky
    jkoritzinsky committed Apr 2, 2024
    Configuration menu
    Copy the full SHA
    7315beb View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' of github.com:dotnet/runtime into misc-pal 

    # Conflicts:
#	src/coreclr/jit/emitarm64.cpp
    @jkoritzinsky
    jkoritzinsky committed Apr 2, 2024
    Configuration menu
    Copy the full SHA
    3b8e067 View commit details
    Browse the repository at this point in the history

  4. Fix build

    @jkoritzinsky
    jkoritzinsky committed Apr 2, 2024
    Configuration menu
    Copy the full SHA
    e71df2d View commit details
    Browse the repository at this point in the history

Commits on Apr 3, 2024

  1. PR feedback

    @jkoritzinsky
    jkoritzinsky committed Apr 3, 2024
    Configuration menu
    Copy the full SHA
    140313a View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' of github.com:dotnet/runtime into misc-pal

    @jkoritzinsky
    jkoritzinsky committed Apr 3, 2024
    Configuration menu
    Copy the full SHA
    e9c5d90 View commit details
    Browse the repository at this point in the history

  3. Convert (TADDR)NULL to (TADDR)0 in places where (TADDR)NULL was not a… 

    …lready in use before this PR.
    @jkoritzinsky
    jkoritzinsky committed Apr 3, 2024
    Configuration menu
    Copy the full SHA
    fca86d3 View commit details
    Browse the repository at this point in the history

  4. Merge dotnet/runtime into jkoritzinsky/misc-pal

    @jkoritzinsky
    jkoritzinsky committed Apr 3, 2024
    Configuration menu
    Copy the full SHA
    3701d49 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'main' of github.com:dotnet/runtime into misc-pal

    @jkoritzinsky
    jkoritzinsky committed Apr 3, 2024
    Configuration menu
    Copy the full SHA
    a0e2e3d View commit details
    Browse the repository at this point in the history