-
Notifications
You must be signed in to change notification settings - Fork 4.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix the new EH with hot-cold split code #99012
Fix the new EH with hot-cold split code #99012
Conversation
The new EH was not taking into account the fact that with hot-cold split methods, the offset used for looking up EH funclets need to be computed as if the hot and cold regions were consecutive in memory. That have caused failures in a number of tests when the tests themselves were compiled with R2R and hot-cold split enabled. Close dotnet#98915, dotnet#98916, dotnet#98917, dotnet#98918
cc: @mangod9 |
/backport to release/9.0-preview |
Started backporting to release/9.0-preview: https://github.com/dotnet/runtime/actions/runs/8070840476 |
Apologies, I gave you the wrong command. |
/backport to release/9.0-preview2 |
Started backporting to release/9.0-preview2: https://github.com/dotnet/runtime/actions/runs/8070854319 |
@janvorli an error occurred while backporting to release/9.0-preview, please check the run log for details! Error: The specified backport target branch release/9.0-preview wasn't found in the repo. |
The new EH was not taking into account the fact that with hot-cold split methods, the offset used for looking up EH funclets need to be computed as if the hot and cold regions were consecutive in memory. That have caused failures in a number of tests when the tests themselves were compiled with R2R and hot-cold split enabled.
Close #98915, #98916, #98917, #98918