[release/9.0-preview2] Fix the new EH with hot-cold split code #99015
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
The new EH was not taking into account the fact that with hot-cold split methods, the offset used for looking up EH funclets need to be computed as if the hot and cold regions were consecutive in memory. That have caused failures in a number of tests when the tests themselves were compiled with R2R and hot-cold split enabled. Close #98915, #98916, #98917, #98918
carlossanlop
added
Servicing-approved
|
Approved by Tactics via email. Need to merge the main PR first. |
carlossanlop
approved these changes
Feb 27, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #99012 to release/9.0-preview2
/cc @carlossanlop @janvorli
Customer Impact
When a customer compiles their own application with R2R and hot/cold code split enabled, the exception handling would miss catch / finally / exception filters in the cold code.
Regression
#98570 - enables the new exception handling by default.
Testing
Local testing and debugging of the tests that have failed due to the problem.
Risk
Low, it doesn't influence behavior with hot-cold splitting disabled, which is the default and has been well tested during the past months.