Add DiagnosticScenarios

[sdmaclea]

Summary

Add sample debug target for use in C# Guide diagnostics scenarios.

[rpetrusha]

Thanks, @sdmaclea. I've left one comment, and @Youssef1313 left several. We shuld also add the sample to the Samples Browser. I've left a second comment with the metadata needed to do that.

[sdmaclea]

Thanks @Maoni0

I have applied all feedback.

I created the related docs PR. #dotnet/docs#14110. It's WIP.

[rpetrusha]

Thanks for making these changes, @sdmaclea. This looks good, although the sample isn't building on the browser review site. Let's leave this open until Tuesday, when I should be able to find out why the sample isn't building.

[sdmaclea]

I tried to build it locally. I found one of the var changes was a syntax error. It should build now. Tuesday is fine.

[Youssef1313]

@sdmaclea, Not sure what causes the usage of var to cause a syntax error. for me, seems that both should build and compile successfully.

but the usage of var follows the coding conventions specified by both, this article and corefx coding style.

[sdmaclea]

@Youssef1313

var is recommended in the article you cite for local variables. The failing case was for class member variables, where they are not recommended and cause the compiler to issue an error (at least by default).

Also the corefx guidance is specifically describes when to not use var.

We only use var when it's obvious what the variable type is (e.g. var stream = new FileStream(...) not var stream = OpenStandardInput()).

[Youssef1313]

@sdmaclea, Oh. Missed the point that it's not a local variable here. Sorry for that.

[rpetrusha]

I'll merge this sample, @sdmaclea, and then we'll see whether it builds successfully.