Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add VB samples zip file #5

Merged
merged 1 commit into from
Apr 2, 2018
Merged

Conversation

BillWagner
Copy link
Member

Noticed when we split the repos.

Noticed when we split the repos.
@mairaw
Copy link
Contributor

mairaw commented Apr 2, 2018

Thanks @BillWagner.

I also had a question on why the vb folder had fewer files than the c# one. Take a look:
https://github.com/dotnet/samples/tree/master/snippets/visualbasic/how-to/conversions
https://github.com/dotnet/samples/tree/master/snippets/csharp/how-to/conversions

By design?

@BillWagner
Copy link
Member Author

@mairaw That's by accidental design. 🤔 I started the C# ones thinking more might end up in the program. It didn't.

Copy link
Contributor

@mairaw mairaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM then 😆

@BillWagner BillWagner merged commit 3d83bbc into dotnet:master Apr 2, 2018
@BillWagner BillWagner deleted the add-vb-zip-file branch April 12, 2018 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants