update sample links #4822

BillWagner · 2018-03-29T21:07:43Z

Related to #4821

All links to samples have moved to a new "dotnet/samples" repo.

edit by @mairaw: removed the fixes keyword

mairaw

We need to also remove the extra samples folder that no longer exists.

mairaw · 2018-03-29T21:33:14Z

docs/core/porting/project-structure.md

@@ -73,14 +73,14 @@ Please see the [.NET Core porting documentation][porting-doc] for more guidance

 [porting-doc]: index.md
 [example-initial-project]: media/project-structure/project.png "Existing project"
-[example-initial-project-code]: https://github.com/dotnet/docs/tree/master/samples/framework/libraries/migrate-library/
+[example-initial-project-code]: https://github.com/dotnet/samples/tree/master/samples/framework/libraries/migrate-library/


e.g. https://github.com/dotnet/samples/tree/master/framework/libraries/migrate-library/

mairaw · 2018-03-30T17:13:47Z

@BillWagner it seems that this PR was also touching one of the api files. can you rebase to fix the conflict? The api folder is now gone from master.

Fixes #4821 All links to samples have moved to a new "dotnet/samples" repo.

The samples repo moved all samples up out of the "samples" directory.

rpetrusha

There are still some broken links to the old samples directory, @BillWagner. I think I've found all of them.

rpetrusha · 2018-03-30T21:08:46Z

docs/core/testing/unit-testing-fsharp-with-dotnet-test.md

@@ -13,7 +13,7 @@ ms.workload:
 ---
 # Unit testing F# libraries in .NET Core using dotnet test and xUnit

-This tutorial takes you through an interactive experience building a sample solution step-by-step to learn unit testing concepts. If you prefer to follow the tutorial using a pre-built solution, [view or download the sample code](https://github.com/dotnet/docs/tree/master/samples/core/getting-started/unit-testing-with-fsharp/) before you begin. For download instructions, see [Samples and Tutorials](../../samples-and-tutorials/index.md#viewing-and-downloading-samples).
+This tutorial takes you through an interactive experience building a sample solution step-by-step to learn unit testing concepts. If you prefer to follow the tutorial using a pre-built solution, [view or download the sample code](https://github.com/dotnet/samples/tree/master/core/getting-started/unit-testing-with-fsharp/) before you begin. For download instructions, see [Samples and Tutorials](../../samples-and-tutorials/index.md#viewing-and-downloading-samples).



On line 70, the link to the samples repository is broken, since it doesn't go to the new repo.

rpetrusha · 2018-03-30T21:14:21Z

docs/core/testing/unit-testing-fsharp-with-mstest.md

@@ -13,7 +13,7 @@ ms.workload:
 ---
 # Unit testing F# libraries in .NET Core using dotnet test and MSTest

-This tutorial takes you through an interactive experience building a sample solution step-by-step to learn unit testing concepts. If you prefer to follow the tutorial using a pre-built solution, [view or download the sample code](https://github.com/dotnet/docs/tree/master/samples/core/getting-started/unit-testing-with-fsharp-mstest/) before you begin. For download instructions, see [Samples and Tutorials](../../samples-and-tutorials/index.md#viewing-and-downloading-samples).
+This tutorial takes you through an interactive experience building a sample solution step-by-step to learn unit testing concepts. If you prefer to follow the tutorial using a pre-built solution, [view or download the sample code](https://github.com/dotnet/samples/tree/master/core/getting-started/unit-testing-with-fsharp-mstest/) before you begin. For download instructions, see [Samples and Tutorials](../../samples-and-tutorials/index.md#viewing-and-downloading-samples).

 ## Creating the source project



Line 70 has a broken link to the samples,

rpetrusha · 2018-03-30T21:15:44Z

docs/core/testing/unit-testing-fsharp-with-nunit.md

@@ -10,7 +10,7 @@ ms.prod: .net-core
 ---
 # Unit testing F# libraries in .NET Core using dotnet test and NUnit

-This tutorial takes you through an interactive experience building a sample solution step-by-step to learn unit testing concepts. If you prefer to follow the tutorial using a pre-built solution, [view or download the sample code](https://github.com/dotnet/docs/tree/master/samples/core/getting-started/unit-testing-with-fsharp-nunit/) before you begin. For download instructions, see [Samples and Tutorials](../../samples-and-tutorials/index.md#viewing-and-downloading-samples).
+This tutorial takes you through an interactive experience building a sample solution step-by-step to learn unit testing concepts. If you prefer to follow the tutorial using a pre-built solution, [view or download the sample code](https://github.com/dotnet/samples/tree/master/core/getting-started/unit-testing-with-fsharp-nunit/) before you begin. For download instructions, see [Samples and Tutorials](../../samples-and-tutorials/index.md#viewing-and-downloading-samples).

 ## Creating the source project



There's a broken link that should go to the new samples repo on line 75.

rpetrusha · 2018-03-30T21:18:14Z

docs/core/testing/unit-testing-visual-basic-with-dotnet-test.md

@@ -13,7 +13,7 @@ ms.workload:
 ---
 # Unit testing Visual Basic .NET Core libraries using dotnet test and xUnit

-This tutorial takes you through an interactive experience building a sample solution step-by-step to learn unit testing concepts. If you prefer to follow the tutorial using a pre-built solution, [view or download the sample code](https://github.com/dotnet/docs/tree/master/samples/core/getting-started/unit-testing-using-dotnet-test/) before you begin. For download instructions, see [Samples and Tutorials](../../samples-and-tutorials/index.md#viewing-and-downloading-samples).
+This tutorial takes you through an interactive experience building a sample solution step-by-step to learn unit testing concepts. If you prefer to follow the tutorial using a pre-built solution, [view or download the sample code](https://github.com/dotnet/samples/tree/master/core/getting-started/unit-testing-using-dotnet-test/) before you begin. For download instructions, see [Samples and Tutorials](../../samples-and-tutorials/index.md#viewing-and-downloading-samples).

 ## Creating the source project



There are broken links that should go to the new samples repo on line 75 and line 143 (2 links).

rpetrusha · 2018-03-30T21:20:41Z

docs/core/testing/unit-testing-visual-basic-with-nunit.md

@@ -10,7 +10,7 @@ ms.prod: .net-core
 ---
 # Unit testing Visual Basic .NET Core libraries using dotnet test and NUnit

-This tutorial takes you through an interactive experience building a sample solution step-by-step to learn unit testing concepts. If you prefer to follow the tutorial using a pre-built solution, [view or download the sample code](https://github.com/dotnet/docs/tree/master/samples/core/getting-started/unit-testing-vb-nunit/) before you begin. For download instructions, see [Samples and Tutorials](../../samples-and-tutorials/index.md#viewing-and-downloading-samples).
+This tutorial takes you through an interactive experience building a sample solution step-by-step to learn unit testing concepts. If you prefer to follow the tutorial using a pre-built solution, [view or download the sample code](https://github.com/dotnet/samples/tree/master/core/getting-started/unit-testing-vb-nunit/) before you begin. For download instructions, see [Samples and Tutorials](../../samples-and-tutorials/index.md#viewing-and-downloading-samples).

 ## Creating the source project



Broken links that should go to the samples repo on lines 80 and 149 (2 links)

rpetrusha · 2018-03-30T21:23:24Z

docs/core/testing/unit-testing-visual-basic-with-mstest.md

@@ -13,7 +13,7 @@ ms.workload:
 ---
 # Unit testing Visual Basic .NET Core libraries using dotnet test and MStest

-This tutorial takes you through an interactive experience building a sample solution step-by-step to learn unit testing concepts. If you prefer to follow the tutorial using a pre-built solution, [view or download the sample code](https://github.com/dotnet/docs/tree/master/samples/core/getting-started/unit-testing-vb-mstest/) before you begin. For download instructions, see [Samples and Tutorials](../../samples-and-tutorials/index.md#viewing-and-downloading-samples).
+This tutorial takes you through an interactive experience building a sample solution step-by-step to learn unit testing concepts. If you prefer to follow the tutorial using a pre-built solution, [view or download the sample code](https://github.com/dotnet/samples/tree/master/core/getting-started/unit-testing-vb-mstest/) before you begin. For download instructions, see [Samples and Tutorials](../../samples-and-tutorials/index.md#viewing-and-downloading-samples).

 ## Creating the source project



broken links that should go to the new samples repo on 77 and 146 (2 links)

rpetrusha · 2018-03-30T21:26:12Z

docs/core/testing/unit-testing-with-dotnet-test.md

@@ -11,7 +11,7 @@ ms.workload:
 ---
 # Unit testing C# in .NET Core using dotnet test and xUnit

-This tutorial takes you through an interactive experience building a sample solution step-by-step to learn unit testing concepts. If you prefer to follow the tutorial using a pre-built solution, [view or download the sample code](https://github.com/dotnet/docs/tree/master/samples/core/getting-started/unit-testing-using-dotnet-test/) before you begin. For download instructions, see [Samples and Tutorials](../../samples-and-tutorials/index.md#viewing-and-downloading-samples).
+This tutorial takes you through an interactive experience building a sample solution step-by-step to learn unit testing concepts. If you prefer to follow the tutorial using a pre-built solution, [view or download the sample code](https://github.com/dotnet/samples/tree/master/core/getting-started/unit-testing-using-dotnet-test/) before you begin. For download instructions, see [Samples and Tutorials](../../samples-and-tutorials/index.md#viewing-and-downloading-samples).

 ## Creating the source project



broken links that should go to the new samples repo on lines 83 and 169 (2 links)

rpetrusha · 2018-03-30T21:41:54Z

docs/csharp/how-to/concatenate-multiple-strings.md

@@ -57,7 +57,7 @@ combines an array of words by adding a space between each word in the array:

 [!code-csharp-interactive[string concatenation using LINQ expressions](../../../samples/snippets/csharp/how-to/strings/Concatenate.cs#6)]  

-You can try these samples by looking at the code in our [GitHub repository](https://github.com/dotnet/docs/tree/master/samples/snippets/csharp/how-to/strings). Or you can download the samples [as a zip file](https://github.com/dotnet/docs/tree/master/samples/snippets/csharp/how-to/strings.zip).
+You can try these samples by looking at the code in our [GitHub repository](https://github.com/dotnet/samples/tree/master/snippets/csharp/how-to/strings). Or you can download the samples [as a zip file](https://github.com/dotnet/samples/tree/master/snippets/csharp/how-to/strings.zip).


nit: If you change tree to raw, the browser just opens the download dialog without displaying the page and requiring the user select the Download button. This applies as well to the other downloadable samples.

I check for all the zip downloads.

rpetrusha · 2018-03-30T21:49:06Z

docs/csharp/tutorials/console-teleprompter.md

@@ -78,7 +78,7 @@ namespace TeleprompterConsole
 ```

 ## Reading and Echoing the File
-The first feature to add is the ability to read a text file and display all that text to the console. First, let’s add a text file. Copy the [sampleQuotes.txt](https://raw.githubusercontent.com/dotnet/docs/master/samples/csharp/getting-started/console-teleprompter/sampleQuotes.txt) file from the GitHub repository for this [sample](https://github.com/dotnet/docs/tree/master/samples/csharp/getting-started/console-teleprompter) into your project directory. This will serve as the script for your application. If you would like information on how to download the sample app for this topic, see the instructions in the [Samples and Tutorials](../../samples-and-tutorials/index.md#viewing-and-downloading-samples) topic.
+The first feature to add is the ability to read a text file and display all that text to the console. First, let’s add a text file. Copy the [sampleQuotes.txt](https://raw.githubusercontent.com/dotnet/docs/master/samples/csharp/getting-started/console-teleprompter/sampleQuotes.txt) file from the GitHub repository for this [sample](https://github.com/dotnet/samples/tree/master/csharp/getting-started/console-teleprompter) into your project directory. This will serve as the script for your application. If you would like information on how to download the sample app for this topic, see the instructions in the [Samples and Tutorials](../../samples-and-tutorials/index.md#viewing-and-downloading-samples) topic.


The link to sampleQuotes.txt is broken.

rpetrusha · 2018-03-30T21:56:25Z

docs/csharp/tutorials/microservices.md

@@ -30,7 +30,7 @@ Along the way, you'll also see some C# language features:
 * How to process incoming HTTP Requests and generate the HTTP Response
 * How to work with nullable value types

-You can [view or download the sample app](https://github.com/dotnet/docs/tree/master/samples/csharp/getting-started/WeatherMicroservice) for this topic. For download instructions, see [Samples and Tutorials](../../samples-and-tutorials/index.md#viewing-and-downloading-samples).
+You can [view or download the sample app](https://github.com/dotnet/samples/tree/master/csharp/getting-started/WeatherMicroservice) for this topic. For download instructions, see [Samples and Tutorials](../../samples-and-tutorials/index.md#viewing-and-downloading-samples).

 ### Why Docker?



On line 128, `http://localhost:5000 resolves as a link, and so produces a broken link. Perhaps it should be fenced.

BillWagner · 2018-03-30T22:17:12Z

Thanks Ron. I also did a global search for blob/master/sample and found a few more that needed to be fixed.

mairaw · 2018-03-31T04:18:32Z

docs/standard/base-types/parsing-datetime.md

@@ -60,7 +60,7 @@ The following example illustrates the use of the <xref:System.DateTime.Parse%2A?
 > All the C# samples in this article run in your browser. Press the **Run** button to see the output. You can also edit them to experiment yourself.

 > [!NOTE]
-> These examples are available in the GitHub docs repo for both [C#](https://github.com/dotnet/docs/samples/tree/master/snippets/csharp/how-to/conversions) and [VB](https://github.com/dotnet/docs/samples/tree/master/snippets/visualbasic/how-to/conversions). Or you can download the project as a zipfile for [C#](https://github.com/dotnet/docs/samples/tree/master/snippets/csharp/how-to/conversions.zip) or [VB](https://github.com/dotnet/docs/samples/tree/master/snippets/visualbasic/how-to/conversions.zip).
+> These examples are available in the GitHub docs repo for both [C#](https://github.com/dotnet/samples/tree/master/snippets/csharp/how-to/conversions) and [VB](https://github.com/dotnet/samples/tree/master/snippets/visualbasic/how-to/conversions). Or you can download the project as a zipfile for [C#](https://github.com/dotnet/samples/raw/master/snippets/csharp/how-to/conversions.zip) or [VB](https://github.com/dotnet/samples/raw/master/snippets/visualbasic/how-to/conversions.zip).


@rpetrusha @BillWagner it would be good to review this topic and these samples. The zip file for VB doesn't exist and the folders don't have the same files.

See dotnet/samples#5 for the vb samples.

mairaw

Fixed all remaining broken links I found except for the VB zip file where I noted that the file doesn't actually exist and files don't match between C# and VB.

BillWagner requested a review from mairaw March 29, 2018 21:07

BillWagner requested a review from rpetrusha as a code owner March 29, 2018 21:07

mairaw requested changes Mar 29, 2018

View reviewed changes

BillWagner added 2 commits March 30, 2018 13:22

update sample links

4856cfa

Fixes #4821 All links to samples have moved to a new "dotnet/samples" repo.

fix destination links

88a7e04

The samples repo moved all samples up out of the "samples" directory.

rpetrusha suggested changes Mar 30, 2018

View reviewed changes

BillWagner and others added 3 commits March 30, 2018 18:17

respond to feedback.

d148d32

fixed broken links

4893a8b

fixed broken links

b0920f2

mairaw reviewed Mar 31, 2018

View reviewed changes

mairaw approved these changes Mar 31, 2018

View reviewed changes

mairaw merged commit 53f3aaa into dotnet:master Mar 31, 2018

BillWagner deleted the fix-sample-links branch March 31, 2018 21:16

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

update sample links #4822

update sample links #4822

BillWagner commented Mar 29, 2018 •

edited by mairaw

Loading

mairaw left a comment

mairaw Mar 29, 2018

mairaw commented Mar 30, 2018

rpetrusha left a comment

rpetrusha Mar 30, 2018

rpetrusha Mar 30, 2018

rpetrusha Mar 30, 2018

rpetrusha Mar 30, 2018

rpetrusha Mar 30, 2018

rpetrusha Mar 30, 2018

rpetrusha Mar 30, 2018

rpetrusha Mar 30, 2018

BillWagner Mar 30, 2018

rpetrusha Mar 30, 2018

rpetrusha Mar 30, 2018

BillWagner commented Mar 30, 2018

mairaw Mar 31, 2018

BillWagner Apr 1, 2018

mairaw left a comment •

edited

Loading

update sample links #4822

update sample links #4822

Conversation

BillWagner commented Mar 29, 2018 • edited by mairaw Loading

mairaw left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mairaw commented Mar 30, 2018

rpetrusha left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

BillWagner commented Mar 30, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mairaw left a comment • edited Loading

Choose a reason for hiding this comment

BillWagner commented Mar 29, 2018 •

edited by mairaw

Loading

mairaw left a comment •

edited

Loading