Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

404 error on link to solution #4821

Closed
mairaw opened this issue Mar 29, 2018 · 8 comments · Fixed by dotnet/samples#1
Closed

404 error on link to solution #4821

mairaw opened this issue Mar 29, 2018 · 8 comments · Fixed by dotnet/samples#1
Assignees
Labels
doc-bug Problem with the content; needs to be fixed [org][type][category] Pri0 Indicates issues or PRs that are critical priority

Comments

@mairaw
Copy link
Contributor

mairaw commented Mar 29, 2018

@dreyses11 commented on Thu Mar 29 2018

In docs.de-de/blob/live/docs/csharp/quick-starts/branches-and-loops-local.md is a link to an solution, but the solution doesn‘t exist (or is wrong linked), so you are recieving an 404 error, when you try to open the link and get to the solution.
image

@mairaw
Copy link
Contributor Author

mairaw commented Mar 29, 2018

@dreyses11 Thanks for reporting this issue and apologies for the inconvenience. The current situation is because of the work for #4789.

We'll update the links to the correct samples once that's done. It should be fixed soon. Thanks!

@mairaw mairaw added this to the Sprint 133 (3/17/18 - 4/06/18) milestone Mar 29, 2018
@mairaw mairaw added doc-bug Problem with the content; needs to be fixed [org][type][category] Pri0 Indicates issues or PRs that are critical priority labels Mar 29, 2018
@mairaw
Copy link
Contributor Author

mairaw commented Mar 29, 2018

@BillWagner are you working on the PR to update the links?

@BillWagner
Copy link
Member

@mairaw

Yes, I should have it tonight or tomorrow morning.

@mairaw
Copy link
Contributor Author

mairaw commented Mar 29, 2018

Cool. Thanks! I'm hoping we can be open for business by tomorrow.

@mairaw mairaw added this to To Do in Sprint 133 (3/17/18 - 4/06/18) - Board View via automation Mar 29, 2018
BillWagner added a commit to dotnet/dotnet-api-docs that referenced this issue Mar 29, 2018
@mairaw mairaw moved this from To Do to In Review (PR -not Merged) in Sprint 133 (3/17/18 - 4/06/18) - Board View Mar 29, 2018
BillWagner added a commit to dotnet/dotnet-api-docs that referenced this issue Mar 30, 2018
Partial fix for dotnet/docs#4821

The samples repo moved all the samples out of a "samples" repo.
BillWagner added a commit to dotnet/dotnet-api-docs that referenced this issue Mar 30, 2018
Partial fix for dotnet/docs#4821

The samples repo moved all the samples out of a "samples" repo.
Sprint 133 (3/17/18 - 4/06/18) - Board View automation moved this from In Review (PR -not Merged) to Done (Merged or Closed) Mar 31, 2018
mairaw pushed a commit to dotnet/dotnet-api-docs that referenced this issue Mar 31, 2018
Partial fix for dotnet/docs#4821

The samples repo moved all the samples out of a "samples" repo.
@mairaw mairaw reopened this Mar 31, 2018
Sprint 133 (3/17/18 - 4/06/18) - Board View automation moved this from Done (Merged or Closed) to Work In progress (WIP) Mar 31, 2018
@mairaw
Copy link
Contributor Author

mairaw commented Mar 31, 2018

Reopening until all PRs are merged

@mairaw
Copy link
Contributor Author

mairaw commented Mar 31, 2018

All PRs are merged now. Still need to fix the vb zip link and wanna do a pass to make sure we didn't miss any.

@BillWagner
Copy link
Member

See dotnet/samples#5 for the VB zip link.

@mairaw
Copy link
Contributor Author

mairaw commented Apr 3, 2018

I think this one can be closed now. Thanks @BillWagner!

@mairaw mairaw closed this as completed Apr 3, 2018
Sprint 133 (3/17/18 - 4/06/18) - Board View automation moved this from Work In progress (WIP) to Done (Merged or Closed) Apr 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc-bug Problem with the content; needs to be fixed [org][type][category] Pri0 Indicates issues or PRs that are critical priority
Projects
No open projects
Sprint 133 (3/17/18 - 4/06/18) - Boar...
  
Done (Merged or Closed)
Development

Successfully merging a pull request may close this issue.

2 participants