Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GenerateAssemblyInfo is not ordered before BeforeCompile #10614

Closed
tmat opened this issue Feb 7, 2020 · 8 comments
Closed

GenerateAssemblyInfo is not ordered before BeforeCompile #10614

tmat opened this issue Feb 7, 2020 · 8 comments
Assignees
Milestone

Comments

@tmat
Copy link
Member

@tmat tmat commented Feb 7, 2020

The common targets convention is to generate all source inputs to the compiler before BeforeCompile target.

Targets that fail to do so break Source Link (see dotnet/sourcelink#572).

@bording

This comment has been minimized.

Copy link

@bording bording commented Feb 7, 2020

@tmat If the fix for this was merged into master, what SDK version does that mean it would arrive in? Does it need to be ported to any other branches?

@tmat

This comment has been minimized.

Copy link
Member Author

@tmat tmat commented Feb 7, 2020

@nguerrera

This comment has been minimized.

Copy link
Member

@nguerrera nguerrera commented Feb 7, 2020

master is 5.0. If this is needed sooner than that, then this would need to be ported to 3.1.2xx to coincide with 16.5. That will require approval at this point. The 16.6 / 3.1.3xx would next opportunity, but branch does not exist yet.

I imagine we could get this approved if you want to put up a port to release/3.1.2xx

@nguerrera nguerrera reopened this Feb 7, 2020
@nguerrera nguerrera added this to the 3.1.2xx milestone Feb 7, 2020
@nguerrera

This comment has been minimized.

Copy link
Member

@nguerrera nguerrera commented Feb 7, 2020

Reopening and targeting 3.1.2xx milestone for now.

@tmat

This comment has been minimized.

Copy link
Member Author

@tmat tmat commented Feb 7, 2020

Yeah, I can port it to release/3.1.2xx.

@nguerrera

This comment has been minimized.

Copy link
Member

@nguerrera nguerrera commented Feb 7, 2020

FYI, @wli3 Note that there is a possibility it will not be approved for 3.1.2xx, but then we can leave the PR open and retarget to 3.1.3xx when the branch opens. That is still much sooner than 5.0.1xx that master is targeting.

@tmat

This comment has been minimized.

Copy link
Member Author

@tmat tmat commented Feb 8, 2020

PR for 3.1.2: #10616

@rainersigwald

This comment has been minimized.

Copy link
Contributor

@rainersigwald rainersigwald commented Mar 25, 2020

#10616 was merged to 3.1.3xx.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

4 participants
You can’t perform that action at this time.