Order GenerateAssemblyInfo target before BeforeCompile (#10613) #10616
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tmat do you need this to be in 16.5? If so, could you create the QB approval bug? |
wli3
changed the title
|
Add WIP for pending QB approval |
|
We can leave it for 16.6. release/3.1.3xx branch does not exist yet, once it will we can retarget this PR to it. |
wli3
changed the title
wli3
changed the title
wli3
added
auto-merge
|
Hello @wli3! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
ghost
merged commit 
|
This is causing lots of pain and creating packages that don't pass validation due to missing sources. Can we get this in to 16.5 / 3.1.2xx? |
|
@clairernovotny do you mind driving approval from QB? |
|
If you show me what I need to do. I think this is important. |
ghost
pushed a commit
that referenced
this pull request
Mar 30, 2020
…w2' (#11047) * update to 3.1.2 runtime (#10699) * Align runtime with v3.1.102 * Update stage0 * Update global.json * Update dependencies from https://github.com/NuGet/NuGet.Client build 5.5.0.6473 (#10722) - NuGet.Build.Tasks - 5.5.0-rtm.6473 * Update branding * Update branding to preview * Order GenerateAssemblyInfo target before BeforeCompile (#10613) (#10616) * Update to nuget build used in cli/toolset * Updating stage 0 * Updating ComputeFilesCopiedToPublishDir to work during design time builds * Simplifying new test * Update NuGet to 5.6.0.6489 (#10847) * Update NuGet to 5.6.0.6489 * Update Version.Details.xml with new NuGet version info * Update stage 0 Co-authored-by: William Li <wul@microsoft.com> Co-authored-by: William Li <wul@microsoft.com> Co-authored-by: dotnet-maestro[bot] <42748379+dotnet-maestro[bot]@users.noreply.github.com> Co-authored-by: Tomáš Matoušek <tmat@users.noreply.github.com> Co-authored-by: Matt Mitchell <mmitche@microsoft.com> Co-authored-by: sfoslund <sfoslund@microsoft.com> Co-authored-by: Luke Westendorf <lukewest@microsoft.com> Co-authored-by: Daniel Plaisted <dsplaisted@gmail.com> Co-authored-by: Andy Zivkovic <zivkan@users.noreply.github.com>
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Port from master.
Fixes #10614