Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When global.json specifies an SDK that can't be found, don't block project load in Visual Studio #11238

Closed
dsplaisted opened this issue Apr 10, 2020 · 1 comment · Fixed by #12633
Assignees
Milestone

Comments

@dsplaisted
Copy link
Member

dsplaisted commented Apr 10, 2020

As described in the "Global.json failures" section of this spec: dotnet/designs#104

We would update the SDK resolver so that when running in Visual Studio, if the requested SDK from global.json is not found, it would fall back to using the SDK that would have been resolved if there was no global.json. It will also set properties or include items indicating that the specified SDK couldn't be found. The SDK will then add a target that will fail the build if it detects these properties or items, giving information about why the resolution failed.

We may need to add the ability for resolvers to read global properties in order for the resolver to know that it's running in VS.

@dsplaisted dsplaisted added this to the 5.0.1xx milestone Apr 10, 2020
@Nirmal4G
Copy link
Contributor

Why not allow something like...

"msbuild-sdks":
{
    "search-paths": [ "src/", "build/sdks/", "env:tmp/sdks", "//server/share/sdks" ]
}

The above pattern will be useful in testing the SDKs locally. Order does matter, obviously! 😁

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants