Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use PublishUrl as default value for PublishDir in .NET SDK #20931

Open
dsplaisted opened this issue Sep 9, 2021 · 2 comments
Open

Use PublishUrl as default value for PublishDir in .NET SDK #20931

dsplaisted opened this issue Sep 9, 2021 · 2 comments
Labels
Area-NetSDK Cost:M 4 to 10 person weeks of work per central guidance good first issue Issues that would be a good fit for someone new to the repository. Narrow in scope, well-defined. new-hire-issue Priority:2 Work that is important, but not critical for the release
Milestone
Backlog

Comments

@dsplaisted
Copy link
Member

Currently, publishing with the Web SDK supports either PublishUrl or PublishDir, but the .NET SDK only supports PublishDir. This can be a problem as the VS tooling to create publish profiles uses PublishUrl.

So we should probably use PublishUrl as the default value for PublishDir.

See dotnet/aspnetcore#35134 (comment)
@Kaelum
Copy link

Kaelum commented Sep 9, 2021

@dsplaisted I very much support this, and Thank You very much! :)

@vijayrkn vijayrkn transferred this issue from dotnet/aspnetcore Sep 10, 2021
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-WebSDK untriaged Request triage from a team member labels Sep 10, 2021
@vijayrkn vijayrkn mentioned this issue Sep 10, 2021
Closed
@vijayrkn vijayrkn mentioned this issue Nov 1, 2021
Open
@marcpopMSFT marcpopMSFT self-assigned this Feb 16, 2022
@marcpopMSFT marcpopMSFT added Area-NetSDK good first issue Issues that would be a good fit for someone new to the repository. Narrow in scope, well-defined. and removed untriaged Request triage from a team member labels Apr 1, 2022
@marcpopMSFT marcpopMSFT added this to the Backlog milestone Apr 1, 2022
@marcpopMSFT marcpopMSFT removed their assignment Apr 1, 2022
@alex-jitbit
Copy link

alex-jitbit commented Aug 15, 2022 •
edited
Loading

Please implement this. Currently we have to keep both ProjectUrl (so that publish works from Visual Studio 2022) and ProjectDir (so that publish works from CLI/CI/CD) in our publish profile file.

And ProjectDir is not even documented anywhere in .NET Core docs

@iksi4prs iksi4prs mentioned this issue Feb 13, 2023
Closed
@nagilson nagilson added new-hire-issue Priority:2 Work that is important, but not critical for the release Cost:M 4 to 10 person weeks of work per central guidance labels May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area-NetSDK Cost:M 4 to 10 person weeks of work per central guidance good first issue Issues that would be a good fit for someone new to the repository. Narrow in scope, well-defined. new-hire-issue Priority:2 Work that is important, but not critical for the release
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
6 participants
@dsplaisted @vijayrkn @marcpopMSFT @nagilson @Kaelum @alex-jitbit