Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect assembly binding redirects generated in 3.0 preview #2795

Closed
yaakov-h opened this issue Jan 8, 2019 · 1 comment
Closed

Incorrect assembly binding redirects generated in 3.0 preview #2795

yaakov-h opened this issue Jan 8, 2019 · 1 comment

Comments

@yaakov-h
Copy link
Member

yaakov-h commented Jan 8, 2019

See: KirillOsenkov/SourceBrowser#108

When building SourceBrowser with SDK v2.1.502, binding redirects for Newtonsoft.Json and System.Collections.Immutable are generated for versions 11.0.0.0 and 1.2.3.0 respectively.

When building SourceBrowser with SDK v3.0.100-preview-009812 (as shipped with VS2019 Preview 1), binding redirects for Newtonsoft.Json and System.Collections.Immutable are generated for versions 9.0.0.0 and 1.2.1.0 respectively.

This appears to be a regression in the SDK.
wli3 pushed a commit that referenced this issue Feb 7, 2020
@dotnet-maestro
Update dependencies from https://github.com/aspnet/websdk build 20190…
4a116f3 
…910.4 (#2795)

- Microsoft.NET.Sdk.Web - 3.0.100-rc2.19460.4
wli3 pushed a commit that referenced this issue Feb 7, 2020
@livarcocc
Merge remote-tracking branch 'upstream/release/3.0.1xx' into merges/r…
79ad646 
…elease/3.0.1xx-to-release/3.1.1xx

* upstream/release/3.0.1xx: (231 commits)
  [release/3.0.1xx] Update dependencies from microsoft/vstest (#2809)
  Update dependencies from https://github.com/dotnet/cli build 20190911.11 (#2823)
  Update dependencies from https://github.com/aspnet/websdk build 20190911.2 (#2816)
  Update dependencies from https://github.com/dotnet/cli build 20190911.1 (#2807)
  Update dependencies from https://github.com/dotnet/cli build 20190910.6 (#2803)
  Update dependencies from https://github.com/aspnet/AspNetCore-Tooling build 20190910.12 (#2801)
  Update dependencies from https://github.com/dotnet/cli build 20190910.5 (#2799)
  Update dependencies from https://github.com/aspnet/websdk build 20190910.5 (#2798)
  Update dependencies from https://github.com/aspnet/AspNetCore-Tooling build 20190910.5 (#2797)
  Update dependencies from https://github.com/dotnet/arcade build 20190910.3 (#2796)
  Update dependencies from https://github.com/dotnet/cli build 20190910.4 (#2794)
  Update dependencies from https://github.com/aspnet/websdk build 20190910.4 (#2795)
  [release/3.0.1xx] Update dependencies from aspnet/AspNetCore-Tooling (#2759)
  Update dependencies from https://github.com/aspnet/websdk build 20190910.2 (#2792)
  Update dependencies from https://github.com/dotnet/core-setup build 20190910.02
  Update dependencies from https://github.com/dotnet/arcade build 20190909.10 (#2788)
  Update dependencies from https://github.com/dotnet/core-setup build 20190909.40 (#2781)
  Update dependencies from https://github.com/Microsoft/msbuild build 20190906.2 (#2779)
  Update dependencies from https://github.com/dotnet/core-setup build 20190909.33 (#2775)
  Update dependencies from https://github.com/dotnet/cli build 20190909.10 (#2771)
  ...

Conflicts:
eng/Version.Details.xml
eng/Versions.props
wli3 pushed a commit that referenced this issue Feb 7, 2020
@livarcocc
Merge remote-tracking branch 'upstream/release/3.1.1xx' into merges/r…
e241daa 
…elease/3.1.1xx-to-master

* upstream/release/3.1.1xx: (603 commits)
  [release/3.0.1xx] Update dependencies from microsoft/vstest (#2809)
  Update dependencies from https://github.com/dotnet/cli build 20190911.11 (#2823)
  Update dependencies from https://github.com/dotnet/cli build 20190911.7 (#2819)
  Update dependencies from https://github.com/dotnet/cli build 20190911.6 (#2818)
  Update dependencies from https://github.com/aspnet/websdk build 20190911.2 (#2816)
  Update dependencies from https://github.com/dotnet/arcade build 20190910.3 (#2815)
  Update dependencies from https://github.com/dotnet/cli build 20190911.1 (#2807)
  Update dependencies from https://github.com/dotnet/fsharp build 20190910.5 (#2804)
  Update dependencies from https://github.com/dotnet/cli build 20190910.6 (#2803)
  Update dependencies from https://github.com/aspnet/AspNetCore-Tooling build 20190910.13 (#2802)
  Update dependencies from https://github.com/aspnet/AspNetCore-Tooling build 20190910.12 (#2801)
  Update dependencies from https://github.com/aspnet/AspNetCore-Tooling build 20190910.11 (#2800)
  Update dependencies from https://github.com/dotnet/cli build 20190910.5 (#2799)
  Update dependencies from https://github.com/aspnet/websdk build 20190910.5 (#2798)
  Update dependencies from https://github.com/aspnet/AspNetCore-Tooling build 20190910.5 (#2797)
  Update dependencies from https://github.com/dotnet/arcade build 20190910.3 (#2796)
  Update dependencies from https://github.com/dotnet/cli build 20190910.4 (#2794)
  Update dependencies from https://github.com/aspnet/websdk build 20190910.4 (#2795)
  Update dependencies from https://github.com/aspnet/AspNetCore-Tooling build 20190910.3 (#2793)
  [release/3.0.1xx] Update dependencies from aspnet/AspNetCore-Tooling (#2759)
  ...

Conflicts:
eng/Version.Details.xml
eng/Versions.props
eng/common/native/install-cmake-test.sh
@MiYanni
Copy link
Member

MiYanni commented Nov 21, 2023

Old bug triage: If this is still an issue, please open a bug on https://github.com/dotnet/msbuild/issues as MSBuild handles binding redirect generation.

@MiYanni MiYanni closed this as not planned Won't fix, can't repro, duplicate, stale Nov 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@yaakov-h @MiYanni