-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Separate copying of refs from preservation of compilation info #2800
Separate copying of refs from preservation of compilation info #2800
Conversation
PreserveCompilationContext does two things today: 1. Write compilation info to .deps 2. Copy reference-only assemblies to build/publish refs/ folder Add PreserveCompilationReferences to control (2) independently and default it to PreserveCompilationContext for backwards compatibility.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Super Approved 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are some Linux test failures, but otherwise this looks good. Perhaps the issue is the tests are targeting .NET Framework and aren't using the targeting pack packages?
Yeah, I thought there was no reason for the test I changed to be Windows only, but apparently there is. :) Looking into it. It seems to find the targeting pack, but then the ref to netstandard.dll does not kick in, so something wrong with extensions? |
…build 20190910.11 (#2800) - Microsoft.NET.Sdk.Razor - 3.1.0-alpha1.19460.11
…elease/3.1.1xx-to-master * upstream/release/3.1.1xx: (603 commits) [release/3.0.1xx] Update dependencies from microsoft/vstest (#2809) Update dependencies from https://github.com/dotnet/cli build 20190911.11 (#2823) Update dependencies from https://github.com/dotnet/cli build 20190911.7 (#2819) Update dependencies from https://github.com/dotnet/cli build 20190911.6 (#2818) Update dependencies from https://github.com/aspnet/websdk build 20190911.2 (#2816) Update dependencies from https://github.com/dotnet/arcade build 20190910.3 (#2815) Update dependencies from https://github.com/dotnet/cli build 20190911.1 (#2807) Update dependencies from https://github.com/dotnet/fsharp build 20190910.5 (#2804) Update dependencies from https://github.com/dotnet/cli build 20190910.6 (#2803) Update dependencies from https://github.com/aspnet/AspNetCore-Tooling build 20190910.13 (#2802) Update dependencies from https://github.com/aspnet/AspNetCore-Tooling build 20190910.12 (#2801) Update dependencies from https://github.com/aspnet/AspNetCore-Tooling build 20190910.11 (#2800) Update dependencies from https://github.com/dotnet/cli build 20190910.5 (#2799) Update dependencies from https://github.com/aspnet/websdk build 20190910.5 (#2798) Update dependencies from https://github.com/aspnet/AspNetCore-Tooling build 20190910.5 (#2797) Update dependencies from https://github.com/dotnet/arcade build 20190910.3 (#2796) Update dependencies from https://github.com/dotnet/cli build 20190910.4 (#2794) Update dependencies from https://github.com/aspnet/websdk build 20190910.4 (#2795) Update dependencies from https://github.com/aspnet/AspNetCore-Tooling build 20190910.3 (#2793) [release/3.0.1xx] Update dependencies from aspnet/AspNetCore-Tooling (#2759) ... Conflicts: eng/Version.Details.xml eng/Versions.props eng/common/native/install-cmake-test.sh
PreserveCompilationContext does two things today:
Add PreserveCompilationReferences to control (2) independently and default it to PreserveCompilationContext for backwards compatibility.
Fix #2122
cc @pranavkm @rynowak @eerhardt