Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ReferencePath to Microsoft.NET.Sdk.props AssemblySearchPaths #2809

Closed
greyb opened this issue Jan 10, 2019 · 1 comment
Closed

Add ReferencePath to Microsoft.NET.Sdk.props AssemblySearchPaths #2809

greyb opened this issue Jan 10, 2019 · 1 comment

Comments

@greyb
Copy link

greyb commented Jan 10, 2019

AssemblySearchPaths has no ReferencePath, why?

@nguerrera
Copy link
Contributor

I assume you mean this:

https://github.com/Microsoft/msbuild/blob/3a844ce00a873d8ca6ba0a8abc0c6b64f772d937/src/Tasks/Microsoft.Common.CurrentVersion.targets#L549

We made an effort in the SDK to be very restrictive about which things are included in the search path as many of the classic defaults are very problematic: $(OutDir) is a race condition, GAC and registry are machine-dependent, etc.

I don't know the history of $(ReferencePath) in the .user file as commented in Common targets, but that seems to be another source of problems if some users use different references than others.

You can add it to the search path yourself via

<PropertyGroup>
  <AssemblySearchPaths>$(AssemblySearchPaths);$(ReferencePath)</AssemblySearchPaths>
</PropertyGroup>

Closing as the limited default search paths by default in SDK are by design.

wli3 pushed a commit that referenced this issue Feb 7, 2020
* Update dependencies from https://github.com/microsoft/vstest build 20190911-01

- Microsoft.NET.Test.Sdk - 16.3.0-preview-20190911-01

* Update dependencies from https://github.com/microsoft/vstest build 20190911-02

- Microsoft.NET.Test.Sdk - 16.3.0-preview-20190911-02
wli3 pushed a commit that referenced this issue Feb 7, 2020
…elease/3.0.1xx-to-release/3.1.1xx

* upstream/release/3.0.1xx: (231 commits)
  [release/3.0.1xx] Update dependencies from microsoft/vstest (#2809)
  Update dependencies from https://github.com/dotnet/cli build 20190911.11 (#2823)
  Update dependencies from https://github.com/aspnet/websdk build 20190911.2 (#2816)
  Update dependencies from https://github.com/dotnet/cli build 20190911.1 (#2807)
  Update dependencies from https://github.com/dotnet/cli build 20190910.6 (#2803)
  Update dependencies from https://github.com/aspnet/AspNetCore-Tooling build 20190910.12 (#2801)
  Update dependencies from https://github.com/dotnet/cli build 20190910.5 (#2799)
  Update dependencies from https://github.com/aspnet/websdk build 20190910.5 (#2798)
  Update dependencies from https://github.com/aspnet/AspNetCore-Tooling build 20190910.5 (#2797)
  Update dependencies from https://github.com/dotnet/arcade build 20190910.3 (#2796)
  Update dependencies from https://github.com/dotnet/cli build 20190910.4 (#2794)
  Update dependencies from https://github.com/aspnet/websdk build 20190910.4 (#2795)
  [release/3.0.1xx] Update dependencies from aspnet/AspNetCore-Tooling (#2759)
  Update dependencies from https://github.com/aspnet/websdk build 20190910.2 (#2792)
  Update dependencies from https://github.com/dotnet/core-setup build 20190910.02
  Update dependencies from https://github.com/dotnet/arcade build 20190909.10 (#2788)
  Update dependencies from https://github.com/dotnet/core-setup build 20190909.40 (#2781)
  Update dependencies from https://github.com/Microsoft/msbuild build 20190906.2 (#2779)
  Update dependencies from https://github.com/dotnet/core-setup build 20190909.33 (#2775)
  Update dependencies from https://github.com/dotnet/cli build 20190909.10 (#2771)
  ...

Conflicts:
eng/Version.Details.xml
eng/Versions.props
wli3 pushed a commit that referenced this issue Feb 7, 2020
…elease/3.1.1xx-to-master

* upstream/release/3.1.1xx: (603 commits)
  [release/3.0.1xx] Update dependencies from microsoft/vstest (#2809)
  Update dependencies from https://github.com/dotnet/cli build 20190911.11 (#2823)
  Update dependencies from https://github.com/dotnet/cli build 20190911.7 (#2819)
  Update dependencies from https://github.com/dotnet/cli build 20190911.6 (#2818)
  Update dependencies from https://github.com/aspnet/websdk build 20190911.2 (#2816)
  Update dependencies from https://github.com/dotnet/arcade build 20190910.3 (#2815)
  Update dependencies from https://github.com/dotnet/cli build 20190911.1 (#2807)
  Update dependencies from https://github.com/dotnet/fsharp build 20190910.5 (#2804)
  Update dependencies from https://github.com/dotnet/cli build 20190910.6 (#2803)
  Update dependencies from https://github.com/aspnet/AspNetCore-Tooling build 20190910.13 (#2802)
  Update dependencies from https://github.com/aspnet/AspNetCore-Tooling build 20190910.12 (#2801)
  Update dependencies from https://github.com/aspnet/AspNetCore-Tooling build 20190910.11 (#2800)
  Update dependencies from https://github.com/dotnet/cli build 20190910.5 (#2799)
  Update dependencies from https://github.com/aspnet/websdk build 20190910.5 (#2798)
  Update dependencies from https://github.com/aspnet/AspNetCore-Tooling build 20190910.5 (#2797)
  Update dependencies from https://github.com/dotnet/arcade build 20190910.3 (#2796)
  Update dependencies from https://github.com/dotnet/cli build 20190910.4 (#2794)
  Update dependencies from https://github.com/aspnet/websdk build 20190910.4 (#2795)
  Update dependencies from https://github.com/aspnet/AspNetCore-Tooling build 20190910.3 (#2793)
  [release/3.0.1xx] Update dependencies from aspnet/AspNetCore-Tooling (#2759)
  ...

Conflicts:
eng/Version.Details.xml
eng/Versions.props
eng/common/native/install-cmake-test.sh
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants