Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-implement deleted StaticFileHandlerTest tests #35971

Open
ViktorHofer opened this issue Oct 10, 2023 · 0 comments
Open

Re-implement deleted StaticFileHandlerTest tests #35971

ViktorHofer opened this issue Oct 10, 2023 · 0 comments
Labels
Area-DotNet Test untriaged Request triage from a team member

Comments

@ViktorHofer
Copy link
Member

#35863 deleted the StaticFileHandlerTest test class because the two tests in it never ran. With the xunit.analyzers update in that PR, those tests were flagged as incorrectly authored (ValueTask return type). We decided to delete the tests as when enabling the tests (by changing ValueTask to Task), Moq threw a runtime exception.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area-DotNet Test untriaged Request triage from a team member
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ViktorHofer