Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert minimum msbuild changes that were checked in to unblock 8.0.1xx codeflow #36216

Open
marcpopMSFT opened this issue Oct 18, 2023 · 0 comments
Open

Revert minimum msbuild changes that were checked in to unblock 8.0.1xx codeflow #36216

marcpopMSFT opened this issue Oct 18, 2023 · 0 comments
Assignees
@marcpopMSFT
Labels
untriaged Request triage from a team member

Comments

@marcpopMSFT
Copy link
Member

marcpopMSFT commented Oct 18, 2023 •
edited
Loading

In this PR, we determined that the current SDK build was not compatible with the 17.8-p1 version of VS that was available on helix. To work around this as we wait for p3 to be avaiable, we disabled all razor/blazor tests when running on an msbuild older than 17.8-p3. The .net core test versions should still run but the full framework leg will be disabled.
#36053

Once we have p3, we should confirm that the tests are running again on full framework and unblock two tests that we had to fully disable
95073a4#diff-f12bc20cbce5f1234d888082e872411f6ceadcbfc8de03276f7249f7336cc49d
b027016#diff-5cbe92ea2aeff57d7985a8f5ef5eb71307247550149c68c4fbf4378b41dc707c
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-Linux untriaged Request triage from a team member labels Oct 18, 2023
@marcpopMSFT marcpopMSFT self-assigned this Jan 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@marcpopMSFT marcpopMSFT

Labels
untriaged Request triage from a team member
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@marcpopMSFT