Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up our System.Text.Json references #39902

Closed
marcpopMSFT opened this issue Mar 29, 2024 · 1 comment · Fixed by #40645
Closed

Clean up our System.Text.Json references #39902

marcpopMSFT opened this issue Mar 29, 2024 · 1 comment · Fixed by #40645
Assignees
Labels
untriaged Request triage from a team member

Comments

@marcpopMSFT
Copy link
Member

In digging through https://github.com/dotnet/sdk/pull/39901/files, we realized that our logic for UseSystemTextJson is a bit off.

We now use system.text.json even on framework builds. I believe @ladipro has a change to make this even more common. On framework, we need to ensure we have an 8.0.0 reference.

For core, we shouldn't have a reference at all (but we add it in a couple of places).

Changes needed:

  1. Ensure all projects that run in framework and use System.Text.Json have an explicit 8.0.0 reference
  2. Put that version in the versions.props file so it's easier to update in main
    a. It appears to be in main already but unused: https://github.com/dotnet/sdk/blob/main/eng/Versions.props#L38
  3. remove the reference in .net core builds where we're accidentally adding it (search for UseSystemTextJson and review the logic there)
@dotnet-issue-labeler dotnet-issue-labeler bot added the untriaged Request triage from a team member label Mar 29, 2024
Copy link

I couldn't figure out the best area label to add to this issue. If you have write-permissions please help me learn by adding exactly one area label.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
untriaged Request triage from a team member
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants