-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Compiler extensibility #4321
Comments
👍 |
At some point we're also going to need to look at how compilation options are specified. Compilers may have their own options they want to provide, etc. Perhaps in that case an intermediary is used (i.e. |
- Split dotnet-compile into dotnet-compile and dotnet-compile-{compiler} - We still need to figure out the protocol and responsibility but this change adds the needed indirection so that compilers can do their thing. - Updated the bootstrap script and kept the commands since we need them to bootstrap the world until we get updates. #52
Jared and I briefly discussed this before he left. I think we want two sets of arguments here: 1) some "compilationOptions" which are portable and 2) some "extra options" that are passed directly to the compiler. The idea is that we want to keep familiarity by keeping the common options the same, but also provide a mechanism to provide compiler-specific and langauge-specific options. |
The common options would be parsed by dotnet-compile, then passed on as command line arguments to the dotnet-compile-[lang], along with the extra options which are just copied verbatim. |
Sounds like a plan! |
Wood also be great if we didnc# sooner than later |
@agocke @jaredpar We need to figure out how to handle source files resolution. Today we have 3 hard coded globbing patterns that look at source files: Ideally this would be handled by the compiler or maybe it requires more metadata somewhere. This library will also be used for the IDE experience so it needs to flow properly and can't only be in the command line invocation (I'd rather not have the IDE do what it does today for csc 😄) |
This is probably done. Opportunistic close. Reopen if needed. Fixed by dotnet/cli#102. |
Fix dependency name showing twice in auto-PR title
We should add an additional
--compiler
argument todotnet compile
.dotnet compile --compiler {compiler}
. In absence of any compiler we'll usecsc
or sniff some sensible default. It can also be specified in theproject.json
fileThe above project would be an f# project and we would execute the equivalent of
dotnet compile --framework dnxcore50 --compiler fsc
. The command line would override whatever was in the file./cc @jaredpar @anurse
The text was updated successfully, but these errors were encountered: