-
-
Notifications
You must be signed in to change notification settings - Fork 398
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build SwiftShader native package for win-arm64
#2066
Comments
In our experience upgrading LLVM versions without dedicated engineering effort to do so always has unforeseen consequences. Recommend waiting for upstream to update here. |
Turns out this requires more build hackery than expected. I'll see how annoying the contribution process is and send some patches upstream if it's not too much. |
Landed upstream: https://swiftshader.googlesource.com/SwiftShader/+/1eaac56def92dfadfb2f49695c7d3c5cd1e1274d%5E%21/ Just need to |
* Fix #2026 * Fix #2000, closes #2005 * Fix #2010 * Fix added AL bug (good thing we had tests!) * Fix #1500 * Undo any unintentional changes * Add nint overloads for things like VertexAttribPointer * Fix build errors * Add more standard cursor shapes * Upversion natives where necessary * Patch notes for 2.21 * Reorder literally a single line * Incorporate #2143/#2066/#2090 in patch notes * Implement IsExtensionPresent for WGL * nit * OpenXR updates? * Fix flawed constant parsing for Vk/XR * Add openxr to patch notes * Update patch notes for 2.21
This can't be done currently because of errors like this:
This is happening because of this code in SwiftShader's
llvm-config.h
which isn't handling Arm64:https://github.com/google/swiftshader/blob/62c59c41e194c288c06739788bb0aad3c86b19bf/third_party/llvm-10.0/configs/windows/include/llvm/Config/llvm-config.h#L17-L23
Which then causes this error to happen:
https://github.com/google/swiftshader/blob/62c59c41e194c288c06739788bb0aad3c86b19bf/third_party/llvm-10.0/configs/windows/include/llvm/Config/llvm-config.h#L44
This should be fairly easy to patch on our end.
While doing this, we should also consider building SwiftShader with LLVM 16 instead of 10 (the default).
The text was updated successfully, but these errors were encountered: