Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for building .NET Core 2.1.4 SDK #258

Closed
3 tasks
tmds opened this issue Oct 25, 2017 · 12 comments
Closed
3 tasks

Support for building .NET Core 2.1.4 SDK #258

tmds opened this issue Oct 25, 2017 · 12 comments

Comments

@tmds
Copy link
Member

tmds commented Oct 25, 2017

I don't know if there is already some support to build this.

@dotnet/source-build-contrib

  • Port dev/release/2.0 to master
  • repo owners port their patch removal from 2.0 servicing to their master (2.1 branch).
  • update the master SHA to masters of submodule repos
@weshaggard
Copy link
Member

We have started working on this by getting all our changes into the master branches. Once I get all those changes into our core repo's I'm going to update source-build master branch to pull in those master/2.1 branches.

@omajid
Copy link
Member

omajid commented Oct 30, 2017

AFAIK @tmds filed this to track staying up to date with dotnet/designs#18. But it looks like #259 is already tracking that. Is there anything special we need to track here? @tmds can we close this?

@tmds
Copy link
Member Author

tmds commented Oct 30, 2017

Looks like @dleeapho and myself created an issue about this at about the same time.
Perhaps we can track our ability to build 2.1 here? WDYT @omajid ?

@dleeapho dleeapho changed the title Support for building .NET Core SDK 2.1 Support for building .NET Core 2.1 Oct 31, 2017
@dleeapho
Copy link
Contributor

I decided to close #259 and track the work here.

@omajid
Copy link
Member

omajid commented Oct 31, 2017

@tmds I was going to say that since Dan and his team are doing the work, they should get to choose which bug they want to use to track this :)

Looks like @dleeapho was kind enough to switch to this one. Thanks, @dleeapho !

@weshaggard
Copy link
Member

#268 is the first step of moving all the core repo's to master pointers for supporting a 2.1 build.

@omajid
Copy link
Member

omajid commented Dec 11, 2017

Hey folks, any updates on having a source-build release for the 2.1 sdk?

@chcosta
Copy link
Member

chcosta commented Dec 11, 2017

@crummel

@dleeapho
Copy link
Contributor

@omajid once the submodule repos branch for 2.1 we'll be updating source-build.

@omajid
Copy link
Member

omajid commented Dec 11, 2017

@dleeapho Hey. Sorry if it was not clear, but I was asking about a release that corresponds to the 2.1 SDK (not runtime). I see 2.1.2 as released already here, so I suppose the repositories must have branched already?

Edit: Is this the wrong issue for the 2.1 SDK? Is that tracked elsewhere?

@tmds tmds changed the title Support for building .NET Core 2.1 Support for building .NET Core 2.1.4 SDK Jan 29, 2018
@tmds
Copy link
Member Author

tmds commented Jan 29, 2018

I have updated the title to better indicate this issue tracks support for building the 2.1.4 SDK. That is: the SDK that uses .NET Core Runtime 2.0 and adds C# 7.2 support.

I think when we version this in Linux packages, we want to use the new versioning scheme already (dotnet/designs#29). So I think it makes sense to version this 2.0.104 (see dotnet/designs#29 (comment)).

I created a separate issue to track support for the new 2.1 runtime and its associated SDK: #315.

@tmds
Copy link
Member Author

tmds commented May 3, 2018

Cleanup old issue.

@tmds tmds closed this as completed May 3, 2018
@markwilkie markwilkie added this to the S135 Apr 30 - May 18 (4/30/2018) milestone May 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants