EmbedUntrackedSources not honoured for F# projects on GitHub

[SteveGilham]

I have a project that includes a build-time generated (and untracked) file of the form

namespace MyNameSpace
module SolutionRoot =
  let location = """some/file/path"""

which is located at some\file\path\_Generated\SolutionRoot.fs

If I build the project with SourceLink (Microsoft.SourceLink.GitHub Version="1.0.0-beta-63127-02") and <EmbedUntrackedSources>true</EmbedUntrackedSources> the untracked file is not detected as such, but is linked by URL instead along with all the others that generate symbols. So when I invoke the sourcelink global tool on the symbols with option test, I get error: url failed NotFound: Not Found when it tries to locate this untracked file in GitHub at the url _Generated\SolutionRoot.fs relative to the current commit root.

Using EmbedAllSources instead does embed every file that generates symbols, including this one, and sourcelink test passes.

I am assuming that as the F# compiler is source-control agnostic, the issue lies somewhere on the SourceLink side.

[tmat]

Could you please run msbuild /bl:log.binlog proj.fsproj and share the resulting log file?

[tmat]

Also, what's the content of .gitignore file? SourceLink determines untracked files based on .gitignore.

[SteveGilham]

Zipped binlog -- log.zip
Zipped .gitignore -- gitignore.zip : the appropriate line of the latter would be _*/

A C# project in this solution happily processes a FAKE generated assembly version file with path _Generated/AssemblyVersion.cs as a file to embed under these circumstances (the equivalent _Generated/AssemblyVersion.fs is a total no-show because all the [<Literal>] values compile with the [DebuggerBrowsable(DebuggerBrowsableState.Never)] attribute)

[tmat]

The log shows that SourceLink identifies correctly the files that need to be embedded:

It seems however that the F# build targets do not read the EmbeddedFiles items. This has been fixed recently in F#: dotnet/fsharp#4075, but the fix doesn't seem to make it to VS 2017 update. Can you try the latest build? See https://github.com/Microsoft/visualfsharp/wiki/Using-CI-Builds

[saul]

@tmat - completely unrelated but what tool are you using to produce the screenshot above? Looks very useful for MSBuild debugging

[bording]

@saul You can get it from http://msbuildlog.com/