Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing readonly modifiers #1508

Merged
merged 1 commit into from Sep 6, 2019

Conversation

@terrajobst
Copy link
Member

commented Sep 6, 2019

I've recently updated the reference assembly generation tool to the latest C# version. This exposed a bug where .NET Standard didn't include readonly modifiers that .NET Core added in 3.0. For the affected APIs these wouldn't cause correctness issues, but it would result in superfluous defensive copies, which, given the size of some of these structs, could result in reduced performance.

/cc @stephentoub @tannergooding

@terrajobst terrajobst requested review from dotnet/nsboard-foundation as code owners Sep 6, 2019

@terrajobst terrajobst force-pushed the terrajobst:missing-read-only branch from 628a1d7 to 83b3114 Sep 6, 2019

@terrajobst terrajobst added the bug label Sep 6, 2019

@terrajobst terrajobst merged commit 54b9828 into dotnet:master Sep 6, 2019

6 checks passed

WIP Ready for review
Details
license/cla All CLA requirements met.
Details
standard-ci Build #20190906.10 succeeded
Details
standard-ci (Build Linux) Build Linux succeeded
Details
standard-ci (Build OSX) Build OSX succeeded
Details
standard-ci (Build Windows_NT) Build Windows_NT succeeded
Details

@terrajobst terrajobst deleted the terrajobst:missing-read-only branch Sep 6, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
7 participants
You can’t perform that action at this time.