This repository has been archived by the owner on Sep 13, 2022. It is now read-only.
Add missing readonly modifiers #1508
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clairernovotny
approved these changes
Sep 6, 2019
tannergooding
approved these changes
Sep 6, 2019
marek-safar
approved these changes
Sep 6, 2019
joshpeterson
approved these changes
Sep 6, 2019
jaredpar
approved these changes
Sep 6, 2019
stephentoub
approved these changes
Sep 6, 2019
terrajobst
force-pushed
the
missing-read-only
branch
from
628a1d7
to
83b3114
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've recently updated the reference assembly generation tool to the latest C# version. This exposed a bug where .NET Standard didn't include
readonlymodifiers that .NET Core added in 3.0. For the affected APIs these wouldn't cause correctness issues, but it would result in superfluous defensive copies, which, given the size of some of these structs, could result in reduced performance./cc @stephentoub @tannergooding