Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to 1ES templates #7734

Merged
merged 20 commits into from
Mar 20, 2024
Merged

Migrate to 1ES templates #7734

merged 20 commits into from
Mar 20, 2024

Conversation

joeloff
Copy link
Member

@joeloff joeloff commented Mar 18, 2024

No description provided.

@joeloff joeloff marked this pull request as ready for review March 19, 2024 21:40
@joeloff joeloff requested a review from a team as a code owner March 19, 2024 21:40
@joeloff joeloff requested a review from MiYanni March 19, 2024 21:41
Copy link
Member

@nagilson nagilson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should delete the code ql pipeline if we arent going to use it anymore

@joeloff
Copy link
Member Author

joeloff commented Mar 19, 2024

I think we should delete the code ql pipeline if we arent going to use it anymore

Deleted

azure-pipelines.yml Outdated Show resolved Hide resolved
@joeloff joeloff merged commit a10f1b6 into dotnet:main Mar 20, 2024
10 checks passed
@joeloff
Copy link
Member Author

joeloff commented Mar 20, 2024

/backport to release/8.0.1xx

Copy link
Contributor

Started backporting to release/8.0.1xx: https://github.com/dotnet/templating/actions/runs/8365381471

Copy link
Contributor

@joeloff backporting to release/8.0.1xx failed, the patch most likely resulted in conflicts:

$ git am --3way --ignore-whitespace --keep-non-patch changes.patch

Applying: Add templates-official and 1ES resource
Applying: Add extends
.git/rebase-apply/patch:231: trailing whitespace.
    
.git/rebase-apply/patch:240: trailing whitespace.
    
.git/rebase-apply/patch:254: trailing whitespace.
    
.git/rebase-apply/patch:274: trailing whitespace.
    
.git/rebase-apply/patch:303: trailing whitespace.
    
warning: squelched 2 whitespace errors
warning: 7 lines add whitespace errors.
Using index info to reconstruct a base tree...
M	azure-pipelines.yml
Falling back to patching base and 3-way merge...
Auto-merging azure-pipelines.yml
CONFLICT (content): Merge conflict in azure-pipelines.yml
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0002 Add extends
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".
Error: The process '/usr/bin/git' failed with exit code 128

Please backport manually!

Copy link
Contributor

@joeloff an error occurred while backporting to release/8.0.1xx, please check the run log for details!

Error: git am failed, most likely due to a merge conflict.

joeloff added a commit to joeloff/templating that referenced this pull request Mar 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants