Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies and remove EOL versions #8060

Merged
merged 3 commits into from
Jun 10, 2024
Merged

Conversation

ViktorHofer
Copy link
Member

The xunit update triggered this error:

error xUnit1048: Support for 'async void' unit
tests is being removed from xUnit.net v3. To
simplify upgrading, convert the test to 'async
Task' instead.
(https://xunit.net/xunit.analyzers/rules/xUnit1048)

The verify update triggered the removal of the
VerifyAttribute which isn't required anymore.

The xunit update triggered this error:
>  error xUnit1048: Support for 'async void' unit
   tests is being removed from xUnit.net v3. To
   simplify upgrading, convert the test to 'async
   Task' instead.
   (https://xunit.net/xunit.analyzers/rules/xUnit1048)

The verify update triggered the removal of the
VerifyAttribute which isn't required anymore.
@ViktorHofer ViktorHofer requested a review from a team as a code owner June 9, 2024 10:21
@ViktorHofer
Copy link
Member Author

ViktorHofer commented Jun 10, 2024

I need to find out how to update the checked-in snapshots :octocat: cc @SimonCropp in case you know how this is done in this repo.

EDIT: Alexander let me know that this is probably not related to verify's serialized data but with the attribute that is automatically generated for the assembly.

@ViktorHofer ViktorHofer enabled auto-merge (squash) June 10, 2024 10:44
@ViktorHofer ViktorHofer merged commit 16e5d81 into main Jun 10, 2024
10 checks passed
@ViktorHofer ViktorHofer deleted the UpdateDependencies branch June 10, 2024 10:54
@SimonCropp
Copy link
Contributor

@ViktorHofer there are several options for snapshot management https://github.com/VerifyTests/Verify?tab=readme-ov-file#snapshot-management

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants