Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dont generate docs for tests #8067

Closed

Conversation

SimonCropp
Copy link
Contributor

speeds up the build and the ide.
and reduces noise in the build output and the ide

speeds up the build and the ide.
and reduces noise in the build output and the ide
@SimonCropp SimonCropp requested a review from a team as a code owner June 10, 2024 05:57
@ViktorHofer
Copy link
Member

ViktorHofer commented Jun 10, 2024

error EnableGenerateDocumentationFile: (NETCORE_ENGINEERING_TELEMETRY=Build) Set MSBuild property 'GenerateDocumentationFile' to 'true' in project file to enable IDE0005 (Remove unnecessary usings/imports) on build (dotnet/roslyn#41640)

Apparently there's a reason to keep it getting produced. The usings analyzers depends on it. Given that, I would just keep them.

@SimonCropp
Copy link
Contributor Author

i would argue that analyser is flawed if it needs xml docs to work out redundant usings.

@ViktorHofer
Copy link
Member

Yeah. See dotnet/roslyn#41640 for more information.

@SimonCropp SimonCropp deleted the dont-generate-docs-for-tests branch June 10, 2024 23:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants