Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

optimizers maximize #1300

Closed
yueyinqiu opened this issue Apr 26, 2024 · 2 comments
Closed

optimizers maximize #1300

yueyinqiu opened this issue Apr 26, 2024 · 2 comments

Comments

@yueyinqiu
Copy link
Contributor

yueyinqiu commented Apr 26, 2024 •
edited
Loading

Found during #1299.

When maximize is true and grad is false, this (in some optimizers' step method) will definitely throw an exception:

image

For instance:

image

I will try to fix this after #1299 has been merged.
@NiklasGustafsson
Copy link
Contributor

It's technically a different problem, but I would suggest lumping it in with #1299.

@yueyinqiu yueyinqiu mentioned this issue Apr 27, 2024
Merged
@yueyinqiu
Copy link
Contributor Author

fixed in #1299

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@NiklasGustafsson @yueyinqiu