Print exceptions as errors

[ocallesp]

[AbhitejJohn]

Tagging the issue here: #1192

[AbhitejJohn]

Is the error message and details the same as what the current service puts out?

[AbhitejJohn]

I'm not super familiar with this code - it is weird though that we have to call both onError and onOutput for an exception?

[colombod]

I agree with @AbhitejJohn point. but the exception is wired on the run result, i think we are doing the wrong thing after the runner has produced the reunResult, probably in the integration part

[colombod]

look in the file doing the integration with the wasrunner :

try/src/Microsoft.TryDotNet.WasmRunner/wwwroot/index.html

Line 30 in 7ae958a

if (r !== null) {

this is where it might loose the exception as it is now serialised across

this is where results are received and passed into the kernel:

try/src/microsoft-trydotnet-editor/src/factory.ts

Line 115 in 7ae958a

case "wasmRunner-result":

this is where the fix proposed from @AbhitejJohn will see the onError :

try/src/microsoft-trydotnet-editor/src/factory.ts

Line 123 in 7ae958a

runRequest.onError(wasmRunnerMessage.message);

But I think is clear the issues is in this point:

try/src/microsoft-trydotnet-editor/src/factory.ts

Line 116 in 7ae958a

polyglotNotebooks.Logger.default.info("WasmRunner execution completed");

[ocallesp]

Just to clarify, the changes on this pr is only using onOutput(e.ToString());
onError() was deleted.

[AbhitejJohn]

@ocallesp : This still seems like the wrong place to make the fix since we aren't really passing the exception details through but just printing it to the output pane as Diego mentions. Can you please take a look at the suggestion above and re-work this? At the moment, this seems like a hack.

[colombod]

Just to clarify, the changes on this pr is only using onOutput(e.ToString()); onError() was deleted.

No really, the point here is to fix the bug in the factory code wiring the messages from the wasmrunner and the kernel in javascript. I think we are missing the ability to complete the commands with command failed correctly. That being the case we will need better tests to make sure all is then flowing into the runresults and events that trydotnet.js consumes and then provides to the integration code with the ui part

[colombod]

@ocalles we still need the suggestion from @AbhitejJohn , the onError call in the try catch block of the wasm runner is missing.
The onError call makes the error from the exception flow as event while the RunResult is a synchronous results that contains all outputs and errors.

Do you have a test that shows that your fix flows into the CSharpProjectWithWasmRunnerIKernel and then captures in the trudtonet.js so that customer integration can display in the output pane.