Merge dev branch into master #76
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Adds coreclr-debug.ts to implement coreclr-debug acquisition and hooks it into omnisharp's activation handler 2. Adds the coreclr-debug directory containing the project.json, NuGet.config and dummy.cs required dotnet restore/publish 3. Adds the debugger section to contributes in package.json 4. Adds .vscodeignore to exclude items not needed at runtime from being packaged TODO: 1. Update project.json references 2. Update NuGet.config to not point to http://dbgnuget (switch to nuget.org once pacakges are published publicly) 3. Create some completion file that we can check for correct complete installation 4. Improve reporting status of acquisition to end user
With this commit, the packages pulled in actually work.
1. Add an install log log all output to our vscode OutputChannel 2. Create an install.complete file that is created only on succesfull installation of the tools. Check for the existence of this file to trigger installation
The new packages use copyFiles so dotnet publish will now copy all files we need from the packages. This requires dotnet cli tools at least as new as 1.0.0.001528 (this is the windows version number at least). With contentFiles packages, we no longer need the copy routine and it's helpers.
Pull packages from the public myget and update the dotnet invocations to use verbose output.
Incorproate coreclr-debug into omnisharp extension (rebasing @chuckries's work against 'dev' branch)
This checkin adds an example tasks.json that should be added to the user's project. Eventually this extension will add code to automatically add this file. This PR adds the file now so that users can easily copy it.
Add a template tasks.json file
'Add tasks.json' command that copied tasks.json into current project
The OmniSharp server may targetting solution file (in the case of MSBuild) or simply a folder (in the case of project.json). If it targeted a folder, we would end up stripping off the innermost folder name when attempting to locate/create the .vscode folder.
Include new coreclr bits and latest debugger packages.
Older versions of .NET CLI didn't correctly copy content files. This adds error detection for when this happens.
Update project.json for coreclr-debug
Fix issue with 'Add tasks.json' command
Add error detection for when content files don't get copied.
Remove dnxcore50 from program path template
Add required aiKey attribute for logging debugger telemetry
removed linux specific steps for dotnet cli setup double-doubled backslash for fileshare added link to HowToConvertPDBs removed fancy " everywhere Modified according to Greggs proposals Use github as feedback Added link to NuGet.Config file All of Greggs proposals included
This commit addresses issue #42 and other licensing concerns -- 1. Update the readme to reference licensing 2. Change the package.json to reference the EULA rather than the source license. 3. Checkin the OpenDebugAD7 license so that it has a home on the web. Needed for its nuget package.
Created instructions on how to set up the .net Core Debugger on Mac&Linux
Update licenses for the C# extension
Silently fail if .NET CLI isn't installed
This commit has the following changes: * Removed references to internal sources * Updated to latest behavior * Updated section on PDBs * Removed line about windows PDBs * Integrated @gregg-miskelly's proposals Note: I'm just squashing @DanielMeixner's commits here. The work is his. :-)
Update coreclr-debug package versions
Fix typo in .NET Core link and remove line about using the OmniSharp extension since that is not relevant for this release.
Update readme.md
debugger.md: link to Portable PDB wiki page
This updates the guidance we have on finding the 'program'
Add --configfile to dotnet commands
Update coreclr-debug nuget packages
The package we are referencing now will be build from the MIEngine preview branch. Prior to this the package was from an MIEngine master branch.
Update MIEngine reference
This reorders and updates the steps that should be applied to each project to make it more clear what to do.
|
👍 Lets ship this thing! |
|
👍 |
chuckries
added a commit
that referenced
this pull request
Mar 10, 2016
Merge dev branch into master for csharp extension 0.3.6 release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge the dev branch into master for the release of ms-vscode.csharp 0.3.6
This brings in, among other things, debugging support for .NET Core.