Cleanup explicit EmbeddedResource items from System.Windows.Forms.csproj

[Shyam-Gupta]

Feedback from EricStj:

Replace all these explicit items with a convention. Seems that you should be able to come up with a globbing convention for these and update the reading code where it doesn't align with the convention (or update items when the convention is insufficient).

[elachlan]

@dreddy-work do the unit/integration tests cover this? I started looking and its relatively simple to change to use globbing.

For System.Windows.Forms.Design, I think this works.

  <!-- Embedded Resources are globbed based on their location. -->
  <ItemGroup>
    <EmbeddedResource Include="Resources\System\ComponentModel\Design\*.ico">
      <Generator>PublicResXFileCodeGenerator</Generator>
      <LogicalName>$System.ComponentModel.Design.([System.String]::Copy('%(FileName)')).ico</LogicalName>
    </EmbeddedResource>
    <EmbeddedResource Include="Resources\System\WinForms\Design\Behavior\*.ico">
      <Generator>PublicResXFileCodeGenerator</Generator>
      <LogicalName>$System.Windows.Forms.Design.Behavior([System.String]::Copy('%(FileName)')).ico</LogicalName>
    </EmbeddedResource>
    <EmbeddedResource Include="Resources\System\WinForms\Design\*.ico">
      <Generator>PublicResXFileCodeGenerator</Generator>
      <LogicalName>$System.ComponentModel.Design([System.String]::Copy('%(FileName)')).ico</LogicalName>
    </EmbeddedResource>
    <EmbeddedResource Include="Resources\System\WinForms\Design\MoverGlyph.bmp">
      <LogicalName>System.Windows.Forms.Design.Behavior.MoverGlyph</LogicalName>
    </EmbeddedResource>
  </ItemGroup>

[dreddy-work]

@elachlan, i doubt we have full test coverage here. Appreciate adding some unit tests. Soem example usage are in this file : https://github.com/dotnet/winforms/blob/main/src/System.Windows.Forms/src/System/Windows/Forms/DataGridViewHeaderCell.cs

[dreddy-work]

Unfortunately the sources that access these bitmaps are behind closed source but the way they accessing these resources is similar to what i pasted above.

[elachlan]

@Tanya-Solyanik is the team okay with renaming resource files to allow for easier globbing? Some of the LogicalName values do not match the file names. Mostly the files located in Resources\System\Windows\Forms\ToolStrip\

So Resources\System\Windows\Forms\ToolStrip\imagetoolstripmenuitem.ico => Resources\System\Windows\Forms\ToolStrip\image.ico