Cleanup explicit EmbeddedResource items from System.Windows.Forms.csproj
#8371
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rename icon files to help with globbing delete redundant icons Add tests for EmbeddedResources
lonitra
reviewed
Dec 13, 2022
lonitra
added
the
📭 waiting-author-feedback
dreddy-work
reviewed
Dec 13, 2022
dreddy-work
reviewed
Dec 13, 2022
src/System.Windows.Forms/tests/UnitTests/System/Windows/Forms/EmbeddedResourceTests.cs
Outdated
Show resolved
Hide resolved
|
nice!. |
ghost
removed
the
📭 waiting-author-feedback
dreddy-work
added
the
ready-to-merge
src/System.Windows.Forms/tests/UnitTests/System/Windows/Forms/EmbeddedResourceTests.cs
Outdated
Show resolved
Hide resolved
src/System.Windows.Forms/tests/UnitTests/System/Windows/Forms/EmbeddedResourceTests.cs
Show resolved
Hide resolved
consolidate globbing sort EmbeddedResourceTests Inline Data for easier lookup
|
@Tanya-Solyanik are you happy with it all now? |
@elachlan - I'll play with this change a bit tonight |
auto-merge was automatically disabled
December 15, 2022 06:41
Head branch was pushed to by a user without write access
|
I had dumped out resource names from the main version of System.Windows.Forms.dll and your PR version, and found one new resource in your version - |
|
Please delete ImageEditor.ico and this PR is good to go! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #49
Related #8358
Microsoft Reviewers: Open in CodeFlow