New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix text in the ThreadExceptionDialog #430

Merged
merged 4 commits into from Feb 13, 2019

Conversation

Projects
None yet
3 participants
@Tanya-Solyanik
Copy link
Member

Tanya-Solyanik commented Feb 12, 2019

Fixed #202

  • replaced hardcoded text that represents a resource name with a get …property that reads this resource
  • replaced explicit \r\n strings in SR.RESX file for system.windows.forms.dll with newlines because resx reader escapes them and as a result we don't have new lines in the displayed text
  • for other assemblies in this repo, I created a tracking issue to fix SR.resx files:
    #429
  • added a test for this dialog to WinformsControlsTest, @zsd4yr - please review, I tested this change by running the app, is there anything else to run

Before:
image

After:
image

@Tanya-Solyanik Tanya-Solyanik requested a review from dotnet/dotnet-winforms as a code owner Feb 12, 2019

* replaced hardcoded text that represents a resource name with a get …
…property that reads this resource

* replaced explicit \r\n strings in SR.RESX file for system.windows.forms.dll with newlines because resx reader escapes them and as a result we don't have new lines in the displayed text
* for other assemblies in this repo, I created a tracking issue to fix resx files:
#429

@Tanya-Solyanik Tanya-Solyanik force-pushed the dev/tanyaso/expDialog branch from a30991b to e075433 Feb 12, 2019

Tanya-Solyanik added some commits Feb 12, 2019

* made test app the default startup project
* fixed an error message in the integration test helper to say what was not found where
@zsd4yr

zsd4yr approved these changes Feb 13, 2019

@Tanya-Solyanik Tanya-Solyanik merged commit 4a983a6 into master Feb 13, 2019

1 check passed

license/cla All CLA requirements met.
Details
@DustinCampbell

This comment has been minimized.

Copy link
Member

DustinCampbell commented Feb 14, 2019

Ah ha! Great!

@zsd4yr zsd4yr deleted the dev/tanyaso/expDialog branch Feb 14, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment