Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add file header template editorconfig #9615

Merged
merged 36 commits into from
Aug 3, 2023
Merged

Add file header template editorconfig #9615

merged 36 commits into from
Aug 3, 2023

Conversation

LeafShi1
Copy link
Member

@LeafShi1 LeafShi1 commented Jul 31, 2023 •
edited
Loading

Proposed changes

  • Add file_header_template to .editorconfig file for .cs and .vb files
  • Change all cs and vb files to use 2-line header

Risk

  • Minimal
Microsoft Reviewers: Open in CodeFlow

Simon Zhao (Beyondsoft Corporation) and others added 16 commits July 25, 2023 15:51
Port TabellayoutPanelDesigner, TabControlDesigner to runtime
e096c03
Fix cloud building error
9c06949
Add FlowPanelDesigner to System.Design.Facade project
54c2393
@LeafShi1
Port MonthCalendarDesigner to runtime (#9536)
5b659e9 
* Port MonthCalendarDesigner to runtime

* Delete unnecessary namespace

* Delete redundant assertions and redundant judgment conditions

* Update MonthCalendarDesigner.cs to use file-scoped namespaces
@elachlan
Fix Cursor.ToString() (#9510)
76e1f0e 
Fixes #9464
* Fix Cursor.ToString - do not look up user-provided cursors in the well known list.
* Add test 
* Fix WinformsControlsTest not showing System.Drawing.Design editors
@Epica3055
Fix items property for multiple checked list boxes shouldn't be displ…
0641450 
…ayed in properties window #5337 (#9570)

Fix items property for multiple checked list boxes should not be displayed in properties window #5337
@elachlan @dreddy-work
Implement ImageListDesigner (#9493)
7c550aa 
* Implement ImageListDesigner

* Refactoring ImageListActionList

* Move AssemblyRef to common

* Changes from review

* Few missed changes

* Revert "Move AssemblyRef to common" and add required changes

---------

Co-authored-by: Devendar Reddy Adulla <dreddy@microsoft.com>
Adjust the codes and fix the test error.
34799f0
@SimonZhao888
Merge branch 'feature/9.0' into Issue_8790_Add_TablelayoutPanelDesign…
1e8afed 
…erAndTabControlDesigner
Update the code of WM_CONTEXTMENU in TabControlDesigner
d2e60c0
Remove TabPageDesigner of SkipList in DesignerAttributeTests
cc538a1
@LeafShi1
Add PrintDialogDesigner.cs
79bfaae
@dreddy-work
Merge pull request #9601 from dotnet/main
47377dd 
merge main into feature/9.0 branch
Simplify code and comments
6ffe728
@LeafShi1
Add license header
a263fc3
@LeafShi1
Add file_header_template to .editorconfig file
f8c5d1a
@ghost ghost assigned LeafShi1 Jul 31, 2023
@LeafShi1 LeafShi1 changed the base branch from main to feature/9.0 July 31, 2023 10:17
@LeafShi1
Copy link
Member Author

LeafShi1 commented Jul 31, 2023 •
edited
Loading

Wait for the build to complete and the Unit tests to pass. So add the draft label.

@ghost ghost added the draft draft PR label Jul 31, 2023
Tanya-Solyanik
Tanya-Solyanik reviewed Jul 31, 2023
View reviewed changes
.editorconfig Outdated Show resolved Hide resolved
Tanya-Solyanik
Tanya-Solyanik reviewed Jul 31, 2023
View reviewed changes
.editorconfig Outdated Show resolved Hide resolved
SimonZhao888
SimonZhao888 previously approved these changes Aug 2, 2023
View reviewed changes
@Tanya-Solyanik
Copy link
Member

can I only add template for the cs file?

Sure!

@Tanya-Solyanik
Copy link
Member

Does the VB crash repro locally?

@LeafShi1
Copy link
Member Author

LeafShi1 commented Aug 2, 2023

Does the VB crash repro locally?

No

@LeafShi1 LeafShi1 marked this pull request as ready for review August 2, 2023 09:58
@LeafShi1 LeafShi1 requested a review from a team as a code owner August 2, 2023 09:58
@LeafShi1 LeafShi1 removed the draft draft PR label Aug 2, 2023
Epica3055
Epica3055 previously approved these changes Aug 2, 2023
View reviewed changes
Tanya-Solyanik
Tanya-Solyanik previously approved these changes Aug 2, 2023
View reviewed changes
@Tanya-Solyanik
Copy link
Member

@LeafShi1 - Could you please add a comment to .editorconfig that explains why .vb files are excluded. `Bvc.dll crashed in the CI build when this rule is enabled for VB." This can be done in a new PR.

@LeafShi1 LeafShi1 changed the base branch from feature/9.0 to main August 3, 2023 01:14
@LeafShi1 LeafShi1 dismissed stale reviews from Tanya-Solyanik and Epica3055 August 3, 2023 01:14

The base branch was changed.

@LeafShi1
Copy link
Member Author

LeafShi1 commented Aug 3, 2023

@LeafShi1 - Could you please add a comment to .editorconfig that explains why .vb files are excluded. `Bvc.dll crashed in the CI build when this rule is enabled for VB." This can be done in a new PR.

OK, I will add that in next PR

Tanya-Solyanik
Tanya-Solyanik approved these changes Aug 3, 2023
View reviewed changes
Copy link
Member

@Tanya-Solyanik Tanya-Solyanik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@Tanya-Solyanik Tanya-Solyanik added the ready-to-merge PRs that are ready to merge but worth notifying the internal team. label Aug 3, 2023
@LeafShi1 LeafShi1 merged commit 1d7467b into main Aug 3, 2023
9 checks passed
@LeafShi1 LeafShi1 deleted the Add_file_header_template_editorconfig branch August 3, 2023 06:05
@ghost ghost added this to the 8.0 RC1 milestone Aug 3, 2023
@ghost ghost removed the ready-to-merge PRs that are ready to merge but worth notifying the internal team. label Aug 3, 2023
@LeafShi1 LeafShi1 mentioned this pull request Aug 7, 2023
Merged
@ghost ghost locked as resolved and limited conversation to collaborators Sep 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@JeremyKuhne JeremyKuhne JeremyKuhne left review comments

@Tanya-Solyanik Tanya-Solyanik Tanya-Solyanik approved these changes

@SimonZhao888 SimonZhao888 SimonZhao888 left review comments

@Epica3055 Epica3055 Epica3055 left review comments

Assignees

@LeafShi1 LeafShi1

Labels
None yet
Projects
None yet
Milestone
.NET 8.0 RC1
Development

Successfully merging this pull request may close these issues.
7 participants
@LeafShi1 @Tanya-Solyanik @JeremyKuhne @SimonZhao888 @Epica3055 @elachlan @dreddy-work