Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Latest asyicio doesn't have a loop= param in start_server function #2

Open
shaneapowell opened this issue Aug 2, 2024 · 1 comment

Comments

@shaneapowell
Copy link

shaneapowell commented Aug 2, 2024

I'm just now trying out your library. So far so good.
But.. I had to make a single "change" to the ipyc/asynchronous.py file. Line 166 and 281

From:

self._server = await asyncio.start_server(self.__handle_connection, host=self._ip_address, port=self._port, loop=self.loop, *args)

To:

self._server = await asyncio.start_server(self.__handle_connection, host=self._ip_address, port=self._port, *args)^M

I'm using asyncio version 3.4.3. It appears they have removed support for the loop= parameter in the start_server function.

@dovedevic
Copy link
Owner

Will definitely have to upgrade the library to support the new asyncio from py3.6. Thanks for pointing that out.

I have plans update the library to make the serialization/deserialization more hidden/automatic and be more developer friendly, as well as a general code clean up. I'll address this issue when I do that. If you'd like you can also send in a PR if you so desire.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants