Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Consolidate showDropdown props #253

Merged
merged 14 commits into from
Jun 10, 2019
Merged

refactor: Consolidate showDropdown props #253

merged 14 commits into from
Jun 10, 2019

Commits on May 9, 2019

  1. feat: Group logically related props together (#242) ⚡️ 

    BREAKING: Property changes

| Description                             | Usage before                                                | Usage after                                                   |
| --------------------------------------- | ----------------------------------------------------------- | ------------------------------------------------------------- |
| Added a new `mode` prop                 | `simpleSelect={true}` / `simpleSelect`                      | `mode='simpleSelect'`                                         |
| Bundled text props into a single object | `placeholderText='My text'`<br>`noMatchesText='No matches'` | `texts={{ placeholder: 'My text', noMatches: 'No matches' }}` |
    @ellinge @mrchief
    ellinge authored and mrchief committed May 9, 2019
    Configuration menu
    Copy the full SHA
    6a632cc View commit details
    Browse the repository at this point in the history

Commits on May 12, 2019

  1. refactor: Update mode to include hierarchical (#251) 

    BREAKING: `hierarchical` prop

`hierarchical` prop is now moved under `mode` prop.

```
// before
<DropdownTreeSelect data={data} hierarchical={true} />

// after
<DropdownTreeSelect data={data} mode="hierarchical" />
```
    @mrchief
    mrchief committed May 12, 2019
    Configuration menu
    Copy the full SHA
    8d064fb View commit details
    Browse the repository at this point in the history

Commits on May 17, 2019

  1. docs: Consolidate showDropdown props

    @mrchief
    mrchief committed May 17, 2019
    Configuration menu
    Copy the full SHA
    2f749cb View commit details
    Browse the repository at this point in the history

Commits on May 18, 2019

  1. feat: Group showDropdown prop

    @mrchief
    mrchief committed May 18, 2019
    Configuration menu
    Copy the full SHA
    9089e12 View commit details
    Browse the repository at this point in the history

  2. chore: Remove console log

    @mrchief
    mrchief committed May 18, 2019
    Configuration menu
    Copy the full SHA
    5e19d5c View commit details
    Browse the repository at this point in the history

  3. fix: Fix aria attributes

    @mrchief
    mrchief committed May 18, 2019
    Configuration menu
    Copy the full SHA
    83ae5ed View commit details
    Browse the repository at this point in the history

  4. fix: Aria attributes

    @mrchief
    mrchief committed May 18, 2019
    Configuration menu
    Copy the full SHA
    d72c255 View commit details
    Browse the repository at this point in the history

  5. fix: Aria attributes

    @mrchief
    mrchief committed May 18, 2019
    Configuration menu
    Copy the full SHA
    0b1806a View commit details
    Browse the repository at this point in the history

Commits on May 20, 2019

  1. fix: A11y error for radio

    @ellinge
    ellinge committed May 20, 2019
    Configuration menu
    Copy the full SHA
    b51121f View commit details
    Browse the repository at this point in the history

Commits on May 21, 2019

  1. test: Test a11y for hierarchical mode as well

    @mrchief
    mrchief committed May 21, 2019
    Configuration menu
    Copy the full SHA
    bf7bfd6 View commit details
    Browse the repository at this point in the history

  2. refactor: Always emit aria-multiselectable attribute

    @mrchief
    mrchief committed May 21, 2019
    Configuration menu
    Copy the full SHA
    269634a View commit details
    Browse the repository at this point in the history

  3. Merge branch 'develop' into feat/group_showDropdown 

    # Conflicts:
#	README.md
#	__snapshots__/src/index.test.js.md
#	__snapshots__/src/index.test.js.snap
#	docs/src/stories/Options/index.js
#	src/a11y/a11y.test.js
#	src/index.js
#	src/index.test.js
#	src/tree-manager/tests/radioSelect.test.js
#	src/tree/index.js
#	types/react-dropdown-tree-select.d.ts
    @mrchief
    mrchief committed May 21, 2019
    Configuration menu
    Copy the full SHA
    9da65c6 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'develop' into feat/group_showDropdown

    @mrchief
    mrchief committed May 21, 2019
    Configuration menu
    Copy the full SHA
    2f6a695 View commit details
    Browse the repository at this point in the history

Commits on Jun 5, 2019

  1. Merge branch 'develop' into feat/group_showDropdown

    @mrchief
    mrchief committed Jun 5, 2019
    Configuration menu
    Copy the full SHA
    b18136d View commit details
    Browse the repository at this point in the history