feat: Group logically related props together (#242) ⚡️ #242
Conversation
Pull Request Test Coverage Report for Build 1150
💛 - Coveralls |
mrchief
changed the title
|
Can you base it off a branch in the repo itself? Or else update your fork for the latest prlint.json (the former is preferable though) |
|
Ok, seems like it's not needed. Updating the branch did the trick. That makes me wonder if we should change that check (to be based off develop always)... Food for thought. |
# Conflicts: # __snapshots__/src/index.test.js.snap
mrchief
changed the title
# Conflicts: # __snapshots__/src/tree-node/index.test.js.snap
BREAKING: Property changes
| Description | Usage before | Usage after |
| --------------------------------------- | ----------------------------------------------------------- | ------------------------------------------------------------- |
| Added a new `mode` prop | `simpleSelect={true}` / `simpleSelect` | `mode='simpleSelect'` |
| Bundled text props into a single object | `placeholderText='My text'`<br>`noMatchesText='No matches'` | `texts={{ placeholder: 'My text', noMatches: 'No matches' }}` |
|
Code Climate has analyzed commit 0a4b010 and detected 0 issues on this pull request. View more on Code Climate. |
mrchief
changed the title
|
@mrchief nothing else we should bundle? showDropdown? |
|
Also the doc changes is not reflected in the d.ts/typings |
I haven't considered any other props yet but let me check and get back to you on that. I'll hold off on releasing a new version until then.
The doc in there looked Ok to me. Do you mean they are not the same verbatim? |
|
Everything else is based up on the doc’s formulation so just a check so that you simply just did not forget. |
|
I got distracted by the fact that the readme is over 10K char limit now. The all-contributors table is probably the biggest culprit. Need to rethink it now. |
|
@ellinge Looking at the types, I was wondering why we are documenting props again there. Is it standard practice in the typescript community? |
|
They are used by the IDE for intellisense (in case of vs code/visual studio) just as documented props in C#. |
|
|
|
Hmmm, I suspected as much. I wonder if there's a way to DRY up this stuff without going over the top. Sometimes duplication is simpler. |
BREAKING CHANGE: Property changes
| Description | Usage before | Usage after |
| --------------------------------------- | ----------------------------------------------------------- | ------------------------------------------------------------- |
| Added a new `mode` prop | `simpleSelect={true}` / `simpleSelect` | `mode='simpleSelect'` |
| Bundled text props into a single object | `placeholderText='My text'`<br>`noMatchesText='No matches'` | `texts={{ placeholder: 'My text', noMatches: 'No matches' }}` |
* feat: Group logically related props together (#242) ⚡️ BREAKING CHANGE: Property changes | Description | Usage before | Usage after | | --------------------------------------- | ----------------------------------------------------------- | ------------------------------------------------------------- | | Added a new `mode` prop | `simpleSelect={true}` / `simpleSelect` | `mode='simpleSelect'` | | Bundled text props into a single object | `placeholderText='My text'`<br>`noMatchesText='No matches'` | `texts={{ placeholder: 'My text', noMatches: 'No matches' }}` |
BREAKING CHANGE: Property changes
| Description | Usage before | Usage after |
| --------------------------------------- | ----------------------------------------------------------- | ------------------------------------------------------------- |
| Added a new `mode` prop | `simpleSelect={true}` / `simpleSelect` | `mode='simpleSelect'` |
| Bundled text props into a single object | `placeholderText='My text'`<br>`noMatchesText='No matches'` | `texts={{ placeholder: 'My text', noMatches: 'No matches' }}` |
* feat: Group logically related props together (#242) ⚡️ BREAKING CHANGE: Property changes | Description | Usage before | Usage after | | --------------------------------------- | ----------------------------------------------------------- | ------------------------------------------------------------- | | Added a new `mode` prop | `simpleSelect={true}` / `simpleSelect` | `mode='simpleSelect'` | | Bundled text props into a single object | `placeholderText='My text'`<br>`noMatchesText='No matches'` | `texts={{ placeholder: 'My text', noMatches: 'No matches' }}` |
BREAKING CHANGE: Property changes
| Description | Usage before | Usage after |
| --------------------------------------- | ----------------------------------------------------------- | ------------------------------------------------------------- |
| Added a new `mode` prop | `simpleSelect={true}` / `simpleSelect` | `mode='simpleSelect'` |
| Bundled text props into a single object | `placeholderText='My text'`<br>`noMatchesText='No matches'` | `texts={{ placeholder: 'My text', noMatches: 'No matches' }}` |
What does it do?
Bundles text props and "mode" (radio/simple) into a single object/prop