Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Download Video link does not work? #10

Open
ilovefood2 opened this issue Jun 18, 2019 · 8 comments
Open

Download Video link does not work? #10

ilovefood2 opened this issue Jun 18, 2019 · 8 comments
Labels
enhancement New feature or request

Comments

@ilovefood2
Copy link

updated to new version, and when Download video shows up, clicking on it does not do anything, known issue?

image

@vide0
Copy link
Member

vide0 commented Jun 18, 2019

Are you using branch 3.x.x?

I haven't pushed the build codes to here. Because I am testing it. You can build codes by yourself.

npm install
npm run build

And put windows library files into %userprofile%\bin if you are Windows user.

@ilovefood2
Copy link
Author

ilovefood2 commented Jun 19, 2019

my bad, I thought it was 3.xx

im Mac user btw

@ilovefood2
Copy link
Author

ok after updating to 3.0.0, clicking on Download link will actually download a .sh file, then have to run sudo sh filename.sh
and then it gets to errors

-> [HttpSkipResponseCommand.cc:240] errorCode=22 The response status is not successful. status=400

I randomly tried a couple videos, same error and sudo is asked each time. before it didn't ask for sudo

@vide0
Copy link
Member

vide0 commented Jun 19, 2019

Actually, 3.x.x is developing, I haven't tested it on Mac. But it doesn't need sudo permission. you can run it via command bash ./download-xxxxx.sh or zsh ./download-xxx.sh. And you can paste the content of log file in temporary directory to here if you meet other download problem.

@vide0
Copy link
Member

vide0 commented Jun 19, 2019

By the way, The original download commands still could be use. And I will push the latest code of branch 3.x.x to here later, you can watch and pull it.

@vide0
Copy link
Member

vide0 commented Jun 19, 2019

@ilovefood2 And can you help to check what happen if you change the download-xxx.sh to download-xx.command and click it in Finder

@ilovefood2
Copy link
Author

ilovefood2 commented Jun 19, 2019

yes original command on top of video webpage still works, if copying it and run in bash, it works fine. but downloaded.sh is asking for sudo to run and even with sudo, gives error too.

changed to .command then it still won't run, by default, it's normal, the downloaded file on mac does not have executable property. so I had to chmod +x file.command, then clicking on it will run then.

actually, just remove .sh extension and add x property will get it run, it's just more manual steps to do compared with ver 2.x.x

btw I am on macOS 10.14.5

@zhangchen91
Copy link

下载中途失败了怎么重试,保留已下载的ts文件不变继续下载新的?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants