Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(types): remove GestureResponderEvent #1524

Merged
merged 4 commits into from
Aug 2, 2023

Conversation

silviuaavram
Copy link
Collaborator

@silviuaavram silviuaavram commented Jul 31, 2023

What:
Replace GestureResponderEvent with BaseSyntheticEvent.

Why:
Remove the need for react-native types.

How:
Replace the type, remove the package.

Checklist:

  • Documentation
  • Tests
  • TypeScript Types
  • Flow Types
  • Ready to be merged

@codecov-commenter
Copy link

Codecov Report

Patch and project coverage have no change.

Comparison is base (b498830) 100.00% compared to head (426cbed) 100.00%.
Report is 1 commits behind head on master.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff            @@
##            master     #1524   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           18        18           
  Lines         1710      1710           
  Branches       511       511           
=========================================
  Hits          1710      1710           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@silviuaavram silviuaavram changed the title fix(react-native): remove GestureResponderEvent fix(types): remove GestureResponderEvent Aug 2, 2023
@silviuaavram silviuaavram merged commit 883a458 into master Aug 2, 2023
1 check passed
@silviuaavram silviuaavram deleted the fix/remove-react-native-types branch August 2, 2023 07:14
@github-actions
Copy link

github-actions bot commented Aug 2, 2023

🎉 This PR is included in version 8.0.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants