Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(hooks): itemToKey prop #1573

Merged
merged 7 commits into from
Mar 3, 2024
Merged

feat(hooks): itemToKey prop #1573

merged 7 commits into from
Mar 3, 2024

Conversation

silviuaavram
Copy link
Collaborator

@silviuaavram silviuaavram commented Feb 28, 2024

What:
Reboot #1529 without the breaking change part.

Why:
Closes #1495.

How:
Initially have both itemToKey and selectedItemChanged props but warn that the latter is going to be deprecated.

Checklist:

  • Documentation
  • Tests
  • TypeScript Types
  • Flow Types
  • Ready to be merged

@codecov-commenter
Copy link

codecov-commenter commented Feb 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (59366d9) to head (261cd86).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff            @@
##            master     #1573   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           18        18           
  Lines         1746      1755    +9     
  Branches       528       529    +1     
=========================================
+ Hits          1746      1755    +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@silviuaavram silviuaavram merged commit a583281 into master Mar 3, 2024
2 checks passed
@silviuaavram silviuaavram deleted the feat/1495-item-to-key-2 branch March 3, 2024 10:09
Copy link

github-actions bot commented Mar 3, 2024

🎉 This PR is included in version 8.4.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Using .indexOf(selectedItem) will lead to unexpected results when items are dynamically fetched objects
2 participants