Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lots of new parser warnings in our Doxygen testsuite after the merges two days ago #6583

Closed
lrineau opened this issue Oct 29, 2018 · 5 comments

Comments

@lrineau
Copy link
Contributor

lrineau commented Oct 29, 2018

In the CGAL open source project, we recently got a lot of (1 thousand) warnings in our documentation testsuite, because of the bug fixed by PR #6558. But, since two days ago, we now have 10 thousand warnings. The regression occurred in the range d94c105..3a42bcf. The new warnings are like:

/build/CGAL-4.14-I-29/doc/AABB_tree/PackageDescription.txt:43: warning: end of comment block while expecting command </div>
/build/CGAL-4.14-I-29/doc/AABB_tree/aabb_tree.txt:42: warning: Unknown option '_linebr' after \image command, expected 'width' or 'height'
/build/CGAL-4.14-I-29/doc/AABB_tree/aabb_tree.txt:43: warning: Illegal command \ref as part of a image
/build/CGAL-4.14-I-29/doc/AABB_tree/aabb_tree.txt:45: warning: Unexpected token TK_HTMLTAG found as part of a image
/build/CGAL-4.14-I-29/doc/AABB_tree/aabb_tree.txt:47: warning: Illegal command @section as part of a image
/build/CGAL-4.14-I-29/doc/AABB_tree/aabb_tree.txt:65: warning: Unexpected token TK_LISTITEM found as part of a image
/build/CGAL-4.14-I-29/doc/AABB_tree/aabb_tree.txt:68: warning: Unexpected token TK_LISTITEM found as part of a image
/build/CGAL-4.14-I-29/doc/AABB_tree/aabb_tree.txt:70: warning: Unexpected token TK_LISTITEM found as part of a image
/build/CGAL-4.14-I-29/doc/AABB_tree/aabb_tree.txt:73: warning: Unexpected token TK_LISTITEM found as part of a image
/build/CGAL-4.14-I-29/doc/AABB_tree/aabb_tree.txt:79: warning: Unexpected token TK_LISTITEM found as part of a image
/build/CGAL-4.14-I-29/doc/AABB_tree/aabb_tree.txt:87: warning: Unexpected token TK_LISTITEM found as part of a image
/build/CGAL-4.14-I-29/doc/AABB_tree/aabb_tree.txt:89: warning: Unexpected token TK_LISTITEM found as part of a image
/build/CGAL-4.14-I-29/doc/AABB_tree/aabb_tree.txt:92: warning: Unexpected token TK_LISTITEM found as part of a image
/build/CGAL-4.14-I-29/doc/AABB_tree/aabb_tree.txt:109: warning: Illegal command \warning as part of a image
/build/CGAL-4.14-I-29/doc/AABB_tree/aabb_tree.txt:111: warning: Unexpected token TK_HTMLTAG found as part of a image
/build/CGAL-4.14-I-29/doc/AABB_tree/aabb_tree.txt:111: warning: Unexpected token TK_HTMLTAG found as part of a image
/build/CGAL-4.14-I-29/doc/AABB_tree/aabb_tree.txt:115: warning: Illegal command @section as part of a image
/build/CGAL-4.14-I-29/doc/AABB_tree/aabb_tree.txt:117: warning: Illegal command @subsection as part of a image
/build/CGAL-4.14-I-29/doc/AABB_tree/aabb_tree.txt:125: warning: Unexpected token TK_HTMLTAG found as part of a image
/build/CGAL-4.14-I-29/doc/AABB_tree/aabb_tree.txt:125: warning: Illegal command \ref as part of a image
/build/CGAL-4.14-I-29/doc/AABB_tree/aabb_tree.txt:125: warning: Illegal command \include as part of a image
/build/CGAL-4.14-I-29/doc/AABB_tree/aabb_tree.txt:127: warning: Illegal command @subsection as part of a image
/build/CGAL-4.14-I-29/doc/AABB_tree/aabb_tree.txt:134: warning: Unexpected token TK_HTMLTAG found as part of a image
/build/CGAL-4.14-I-29/doc/AABB_tree/aabb_tree.txt:134: warning: Unexpected token TK_HTMLTAG found as part of a image
/build/CGAL-4.14-I-29/doc/AABB_tree/aabb_tree.txt:141: warning: Unexpected token TK_HTMLTAG found as part of a image
/build/CGAL-4.14-I-29/doc/AABB_tree/aabb_tree.txt:141: warning: Illegal command \ref as part of a image
/build/CGAL-4.14-I-29/doc/AABB_tree/aabb_tree.txt:141: warning: Illegal command \include as part of a image
/build/CGAL-4.14-I-29/doc/AABB_tree/aabb_tree.txt:144: warning: Illegal command @subsection as part of a image

It seems those two commits are related to the parser, and were merged two days ago:

  • dff7c1a Renamed command and moved duplicated code into a macro and
  • a68e6c0 Correcting warning messages and echoing unknown command.

Might it be another consequence of PR #6558, revealed by a68e6c0, or is it a regression of Doxygen?

@albert-github Remember you can compile the documentation of CGAL by yourself, with the instructions from @sloriot, here: #6548 (comment)

Cc: @maxGimeno @afabri

@albert-github
Copy link
Collaborator

I do remember (fortunately I documented also my steps and the directory still existed)
Pull request #6558 has not yet been merged so some messages are expected but this amount ...

I just ran it on the master source stack from October 15, 2018.

I did a pull request so uptodate at October 28, 2018 around 16.00.

So I think the problem is solved when issue #6558 is merged. I contacted Dimitri for this as well (@doxygen)

@lrineau Can you confirm this?

@albert-github albert-github added the needinfo reported bug is incomplete, please add additional info label Oct 29, 2018
@sloriot
Copy link

sloriot commented Oct 30, 2018

I confirm that #6558 fixes the issues.

@albert-github albert-github added bug and removed needinfo reported bug is incomplete, please add additional info labels Oct 30, 2018
@albert-github
Copy link
Collaborator

albert-github commented Oct 30, 2018

Duplicate of #6547

@albert-github albert-github marked this as a duplicate of #6548 Oct 30, 2018
@sloriot
Copy link

sloriot commented Oct 30, 2018

IMHO, an issue in the master branch shouldn't be marked as a duplicate of a PR merged 17 days ago :)

@albert-github
Copy link
Collaborator

Would have been better to mark it as duplicate of #6547.

@albert-github albert-github marked this as a duplicate of #6547 Oct 30, 2018
@albert-github albert-github marked this as not a duplicate of #6548 Oct 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants