Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please add support for VISUAL environment variable and only fall back to EDITOR if the former is either empty or not set #43

Closed
rjc opened this issue Mar 1, 2021 · 2 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@rjc
Copy link

rjc commented Mar 1, 2021

Hello,

I use EDITOR as well as VISUAL environment variables:

EDITOR=ed
VISUAL=vi

Both have their uses and mean different things. Most command line tools use VISUAL and only fall back to EDITOR if the former is either empty or not set, in the following order: VISUAL -> EDITOR -> vi, i.e.: ${VISUAL:-${EDITOR:-vi}}.

It would be great if a visual editor, i.e vi(1), could be used while editing entries using rbw edit ...
lastpass-cli had the same issue a while back ;^)

@rjc rjc changed the title Please add support to VISUAL environment variable and only fall back to EDITOR if the former is either empty or not set Please add support for VISUAL environment variable and only fall back to EDITOR if the former is either empty or not set Mar 1, 2021
@doy doy added enhancement New feature or request good first issue Good for newcomers labels Mar 2, 2021
@doy
Copy link
Owner

doy commented Mar 3, 2021

fixed in 7e52936

@doy doy closed this as completed Mar 3, 2021
@rjc
Copy link
Author

rjc commented Mar 3, 2021

Thank you, much obliged! :^)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants