Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Output last line terminator option for CsvWriter class #18

Closed
doyaaaaaken opened this issue Aug 22, 2019 · 1 comment
Closed

Output last line terminator option for CsvWriter class #18

doyaaaaaken opened this issue Aug 22, 2019 · 1 comment
Assignees
@doyaaaaaken
Labels
enhancement New feature good first issue Good for newcomers help wanted Extra attention is needed in progress Something working on currently

Comments

@doyaaaaaken
Copy link
Collaborator

According to CSV specification,
there may be line break or not at the end of the file.

The last record in the file may or may not have an ending line break.

So, introduce the below option.

val writer = csvWriter {
    outputLastLineTerminator = false
}
@doyaaaaaken doyaaaaaken added enhancement New feature good first issue Good for newcomers labels Aug 22, 2019
@doyaaaaaken doyaaaaaken added the help wanted Extra attention is needed label May 23, 2020
blackmo18 pushed a commit to blackmo18/kotlin-csv that referenced this issue May 26, 2020
jsoizo#18 Output last line terminator option for CsvWriter class
06c95bc 
 - Added Option to CsvWriterContext
 - Added State and State Handler in CsvWriter
     * this due to in CsvWriter open method it is
       allowed to write in multiple ways and order of:
         1. writeRow
         2. writeRows
   - Added Test
@blackmo18 blackmo18 mentioned this issue May 26, 2020
Merged
blackmo18 pushed a commit to blackmo18/kotlin-csv that referenced this issue May 26, 2020
jsoizo#18 Output last line terminator option for CsvWriter class
7adb956 
 - Added Option to CsvWriterContext
 - Added State and State Handler in CsvWriter
     * this due to in CsvWriter open method it is
       allowed to write in multiple ways and order of:
         1. writeRow
         2. writeRows
 - Added Test
@doyaaaaaken doyaaaaaken added the in progress Something working on currently label May 27, 2020
@doyaaaaaken
Copy link
Collaborator Author

plan to release in version 0.10.0 after some refactoring.

@doyaaaaaken doyaaaaaken self-assigned this May 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@doyaaaaaken doyaaaaaken

Labels
enhancement New feature good first issue Good for newcomers help wanted Extra attention is needed in progress Something working on currently
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@doyaaaaaken