Add isolated prop to component
#179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cha, as per google documentation
README.md
Outdated
| @@ -53,6 +53,7 @@ Properties used to customise the rendering: | |||
| | tabindex | number | *optional* The tabindex on the element *(__default:__ `0`)* | |||
| | type | enum | *optional* `image` or `audio` The type of initial captcha *(__defaults:__ `image`)* | |||
| | theme | enum | *optional* `light` or `dark` The theme of the widget *(__defaults:__ `light`)*. See [example][docs_theme] | |||
| | isolated | bool | *optional* For plugin owners to not interfere with existing reCAPTCHA installations on a page. If true, this reCAPTCHA instance will be part of a separate ID space. *(__default:__ `false`)* | |||
There was a problem hiding this comment.
This could be great to order he properties for readability.
|
Thanks! |
hartzis
reviewed
Jul 11, 2020
| @@ -174,6 +176,7 @@ ReCAPTCHA.propTypes = { | |||
| stoken: PropTypes.string, | |||
| hl: PropTypes.string, | |||
| badge: PropTypes.oneOf(["bottomright", "bottomleft", "inline"]), | |||
| isolated: PropTypes.bool, | |||
There was a problem hiding this comment.
❓ should we add a default prop value for isolated?
isolated: false
There was a problem hiding this comment.
I chose not to implement a default value because:
- It is not a required prop, and
- Google reCAPTCHA script defaults this to false anyway when not supplied - see docs
Open to discussion though!
hartzis
approved these changes
Jul 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Google documentation details an
isolatedparameter that can be passed to the render.This PR exposes
isolatedas a component prop, allowing it to be optionally set.